AbstractProductMeasure #110
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportBase: 53.32% // Head: 53.10% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #110 +/- ##
==========================================
- Coverage 53.32% 53.10% -0.22%
==========================================
Files 42 42
Lines 1189 1192 +3
==========================================
- Hits 634 633 -1
- Misses 555 559 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's currently awkward to define methods for
AbstractProductMeasures, because that abstract type doesn't know anything about the underlying structure.This PR explores one possibility for fixing that. The idea is that types
should satisfy
The
Mcould be an abstract type, even as far asstruct T <: AbstractProductMeasure{AbstractArray}or evenstruct T <: AbstractProductMeasure{Any}. More specific instances would just inherit more methods.What do you think @oschulz? No rush :)