AbstractInterpreter: define new infresult_iterator interface
#44000
+46
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aviatesk
commented
Feb 1, 2022
Comment on lines
+377
to
+380
| valid_worlds::WorldRange, result::InferenceResult) | ||
| inferred_result = result.src |
There was a problem hiding this comment.
The reason for this change is that identity of InferenceResult can be used as a key for inference cache and so it is sometimes very useful for customizing the behavior of caching mechanism of the native compilation pipeline.
Keno
reviewed
Feb 1, 2022
base/compiler/typeinfer.jl
Outdated
|
|
||
| struct InfResultInfo | ||
| caller::InferenceResult | ||
| edges::Vector{Any} |
There was a problem hiding this comment.
Maybe these should just be inside InferenceResult then?
Keno
approved these changes
Feb 1, 2022
to make it easier to customize the behaviors of post processing of `_typeinf`. Especially, this change is motivated by a need for JET, whose post processing requires references of `InferenceState`s. Separated from #43994.
aviatesk
force-pushed
the
avi/infresult_iterator
branch
from
b2334af
to
fdc8b00
Compare
vtjnash
reviewed
Feb 22, 2022
| @@ -122,14 +122,15 @@ mutable struct InferenceResult | |||
| overridden_by_const::BitVector | |||
| result # ::Type, or InferenceState if WIP | |||
| src # ::Union{CodeInfo, OptimizationState} if inferred copy is available, nothing otherwise | |||
| edges::Vector{Any} # backedges for this result | |||
There was a problem hiding this comment.
This seems a bit out of place here, since the others are either the keys describing this, or the inferred type results. This is neither (it is internal state of the optimizer)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to make it easier to customize the behaviors of post processing of
_typeinf.Especially, this change is motivated by a need for JET, whose post processing
requires references of
InferenceStates.Separated from #43994.