Fix CI tests for macoOS and ubuntu OS. #538
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cncastillo
reviewed
Jan 27, 2025
.github/workflows/CI.yml
Outdated
| @@ -19,7 +19,7 @@ jobs: | |||
| version: | |||
| - '1.10' # Replace this with the minimum Julia version that your package supports. E.g. if your package requires Julia 1.5 or higher, change this to '1.5'. | |||
| - '1' # Leave this line unchanged. '1' will automatically expand to the latest stable 1.x release of Julia. | |||
| os: [ubuntu-latest, windows-latest, macos-latest] | |||
There was a problem hiding this comment.
Why Is macos-latest not working? Is it because of Kaileido_jll? Check the PR I created about that.
| # Opens UI | ||
| w = KomaUI(return_window=true) | ||
|
|
||
| @unsafe_blink |
There was a problem hiding this comment.
Yo actually fix the bug (opposed to only fix the tests) the call to the macro needs to be inside the KomaUI function.
|
@Stockless can you reply to the comments 🙏 ? |
|
please don't include changes from other PRs without merging them properly, so the ownership of the changes is not changed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the CI test for macOS replacing the OS version from macOS-latest to macOS-13, and the test for Ubuntu adding a macro to avoid the generation of a sandbox in the creation of the gui window, that is causing an issue due to a bug in the latest version of Ubuntu (Ubuntu 24.04.1)