Save yarn locally to workaround setup-node issue #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setup-node refuses to add an option for enabling corepack due to it being marked experimental. This unwittingly resulted in us using the globally installed yarn v1 version for building, despite our expectation that yarn v4 would be used. Rather than do a dance of enabling corepack and setting up node, this saves yarn locally and checks it into git.
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
shakuzen
added a commit
to shakuzen/JapanFinance.github.io
that referenced
this pull request
Aug 3, 2024
Setup-node refuses to add an option for enabling corepack due to it being marked experimental. This unwittingly resulted in us using the globally installed yarn v1 version for building, despite our expectation that yarn v4 would be used. Rather than do a dance of enabling corepack and setting up node, this saves yarn locally and checks it into git.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setup-node refuses to add an option for enabling corepack due to it being marked experimental. This unwittingly resulted in us using the globally installed yarn v1 version for building on GitHub Actions, despite our expectation that yarn v4 would be used. Rather than do a dance of enabling corepack and setting up node, this saves yarn locally and checks it into git.
Also bumps yarn from 4.0.1 to 4.0.2.
See actions/setup-node#899 which we started seeing, for example https://github.com/JapanFinance/JapanFinance.github.io/actions/runs/6909375623/job/18800585931?pr=46. It doesn't happen on every build, as a rebuild passed.
This situation could have been avoided if setup-node had an option to enable
corepack; see actions/setup-node#531.