Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #11799: Resolved file renaming dialog issue and made it resizable #12518

Merged
merged 3 commits into from
Feb 19, 2025

Conversation

Satyamkumarnavneet
Copy link
Contributor

@Satyamkumarnavneet Satyamkumarnavneet commented Feb 17, 2025

This pull request resolves #11799 by:

  • Setting a preferred size for the file renaming dialog (500x200) to accommodate long file names and improve usability.
  • Adding setResizable(true) to allow users to resize the dialog, providing greater flexibility across different screen sizes and resolutions.

Mandatory checks

  • I own the copyright of the code submitted and I licence it under the MIT license
  • Change in CHANGELOG.md described in a way that is understandable for the average user (if change is visible to the user)
  • [/] Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not force-push! Force push is off limits and very bad style when working together on a project. (Mainly because it is not supported well by GitHub istself.) Commits will be lost, comments on commits will loose their context. This makes it harder to review. In the end, all commits will be squashed either way before being merged into the `main`` branch.

@Satyamkumarnavneet Satyamkumarnavneet force-pushed the fix-dialog-issue branch 2 times, most recently from 5046edd to 54bd076 Compare February 17, 2025 13:14
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not force-push! Force push is off limits and very bad style when working together on a project. (Mainly because it is not supported well by GitHub istself.) Commits will be lost, comments on commits will loose their context. This makes it harder to review. In the end, all commits will be squashed either way before being merged into the `main`` branch.

koppor
koppor previously requested changes Feb 17, 2025
Copy link
Member

@koppor koppor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any screenshot before and after - I cannot judge the prefsize values.

@@ -178,6 +178,8 @@ public Optional<String> showInputDialogWithDefaultAndWait(String title, String c
inputDialog.setHeaderText(title);
inputDialog.setContentText(content);
inputDialog.initOwner(mainWindow);
inputDialog.getDialogPane().setPrefSize(500, 200); // Set preferred size
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment seems to be AI-generated and does not add any value (because the method name already says htat)

Suggested change
inputDialog.getDialogPane().setPrefSize(500, 200); // Set preferred size
inputDialog.getDialogPane().setPrefSize(500, 200);

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initially, I added it for my understanding and to pinpoint the correct part of the code. I have now removed it!

@Satyamkumarnavneet
Copy link
Contributor Author

I don't see any screenshot before and after - I cannot judge the prefsize values.

Here is the screenshot you requested:

Screenshot 2025-02-17 at 7 26 58 PM

@Siedlerchr
Copy link
Member

Please make the Edit dialog also resizable. when you click "Edit"

@Siedlerchr
Copy link
Member

Follow up, make the edit dialog also resizable

@Siedlerchr Siedlerchr enabled auto-merge February 19, 2025 18:28
@Siedlerchr Siedlerchr added this pull request to the merge queue Feb 19, 2025
Merged via the queue into JabRef:main with commit 800d44d Feb 19, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make file renaming dialog resizable
3 participants