-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #11799: Resolved file renaming dialog issue and made it resizable #12518
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not force-push! Force push is off limits and very bad style when working together on a project. (Mainly because it is not supported well by GitHub istself.) Commits will be lost, comments on commits will loose their context. This makes it harder to review. In the end, all commits will be squashed either way before being merged into the `main`` branch.
5046edd
to
54bd076
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not force-push! Force push is off limits and very bad style when working together on a project. (Mainly because it is not supported well by GitHub istself.) Commits will be lost, comments on commits will loose their context. This makes it harder to review. In the end, all commits will be squashed either way before being merged into the `main`` branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see any screenshot before and after - I cannot judge the prefsize values.
@@ -178,6 +178,8 @@ public Optional<String> showInputDialogWithDefaultAndWait(String title, String c | |||
inputDialog.setHeaderText(title); | |||
inputDialog.setContentText(content); | |||
inputDialog.initOwner(mainWindow); | |||
inputDialog.getDialogPane().setPrefSize(500, 200); // Set preferred size |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment seems to be AI-generated and does not add any value (because the method name already says htat)
inputDialog.getDialogPane().setPrefSize(500, 200); // Set preferred size | |
inputDialog.getDialogPane().setPrefSize(500, 200); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initially, I added it for my understanding and to pinpoint the correct part of the code. I have now removed it!
Please make the Edit dialog also resizable. when you click "Edit" |
Follow up, make the edit dialog also resizable |
This pull request resolves #11799 by:
Mandatory checks
CHANGELOG.md
described in a way that is understandable for the average user (if change is visible to the user)