Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add drop down for citation key patterns #12516

Merged
merged 19 commits into from
Feb 21, 2025
Merged
Show file tree
Hide file tree
Changes from 10 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,121 @@
package org.jabref.gui.commonfxcontrols;

import java.util.ArrayList;
import java.util.List;
import java.util.stream.Collectors;

import javafx.scene.control.ContextMenu;
import javafx.scene.control.CustomMenuItem;
import javafx.scene.control.Label;
import javafx.scene.control.TextField;
import javafx.scene.control.cell.TextFieldTableCell;

public class CitationKeyPatternSuggestionCell extends TextFieldTableCell<CitationKeyPatternsPanelItemModel, String> {
private final CitationKeyPatternSuggestoinTextField searchField;

public CitationKeyPatternSuggestionCell(List<String> citationKeyPatterns) {
this.searchField = new CitationKeyPatternSuggestoinTextField(citationKeyPatterns);
searchField.setOnAction(event -> commitEdit(searchField.getText()));
}

@Override
public void startEdit() {
super.startEdit();
searchField.setText(getItem());
setGraphic(searchField);
searchField.requestFocus();
}

@Override
public void cancelEdit() {
super.cancelEdit();
setGraphic(null);
}

@Override
public void commitEdit(String newValue) {
super.commitEdit(newValue);
getTableView().getItems().get(getIndex()).setPattern(newValue);
setGraphic(null);
}

@Override
public void updateItem(String item, boolean empty) {
super.updateItem(item, empty);
if (empty || item == null) {
setGraphic(null);
setText(null);
} else {
setText(item);
}
}

static class CitationKeyPatternSuggestoinTextField extends TextField {
private final List<String> citationKeyPatterns;
private final ContextMenu suggestionsList;

public CitationKeyPatternSuggestoinTextField(List<String> citationKeyPatterns) {
this.citationKeyPatterns = new ArrayList<>(citationKeyPatterns);
this.suggestionsList = new ContextMenu();

setListener();
}

private void setListener() {
textProperty().addListener((observable, oldValue, newValue) -> {
String enteredText = getText();
if (enteredText == null || enteredText.isEmpty()) {
suggestionsList.hide();
} else {
List<String> filteredEntries = citationKeyPatterns.stream()
.filter(e -> e.toLowerCase().contains(enteredText.toLowerCase()))
.collect(Collectors.toList());
if (!filteredEntries.isEmpty()) {
populatePopup(filteredEntries);
if (!suggestionsList.isShowing() && getScene() != null) {
double screenX = localToScreen(0, 0).getX();
double screenY = localToScreen(0, 0).getY() + getHeight();
suggestionsList.show(this, screenX, screenY);
}
} else {
suggestionsList.hide();
}
}
});

focusedProperty().addListener((observable, oldValue, newValue) -> {
suggestionsList.hide();
});
}

private void populatePopup(List<String> searchResult) {
List<CustomMenuItem> menuItems = new ArrayList<>();
int maxEntries = 7;
Copy link
Member

@subhramit subhramit Feb 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move this to a class-level constant with a brief comment explaining its use and the value

int count = Math.min(searchResult.size(), maxEntries);

for (int i = 0; i < count; i++) {
final String result = searchResult.get(i);
Label entryLabel = new Label(result);
entryLabel.setPrefWidth(getWidth());

CustomMenuItem item = new CustomMenuItem(entryLabel, true);
item.setHideOnClick(false);

menuItems.add(item);

item.setOnAction(actionEvent -> {
setText(result);
positionCaret(result.length());
suggestionsList.hide();
});
}

suggestionsList.getItems().clear();
suggestionsList.getItems().addAll(menuItems);

if (!menuItems.isEmpty()) {
menuItems.getFirst().getContent().requestFocus();
}
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -4,16 +4,18 @@

import javafx.beans.property.ListProperty;
import javafx.beans.property.ObjectProperty;
import javafx.collections.FXCollections;
import javafx.collections.ObservableList;
import javafx.fxml.FXML;
import javafx.scene.control.TableColumn;
import javafx.scene.control.TableRow;
import javafx.scene.control.TableView;
import javafx.scene.control.cell.TextFieldTableCell;
import javafx.scene.input.KeyEvent;

import org.jabref.gui.icon.IconTheme;
import org.jabref.gui.util.ValueTableCellFactory;
import org.jabref.logic.citationkeypattern.AbstractCitationKeyPatterns;
import org.jabref.logic.citationkeypattern.CitationKeyPattern;
import org.jabref.logic.l10n.Localization;
import org.jabref.logic.preferences.CliPreferences;
import org.jabref.model.entry.BibEntryType;
Expand All @@ -34,9 +36,15 @@ public class CitationKeyPatternsPanel extends TableView<CitationKeyPatternsPanel

private long lastKeyPressTime;
private String tableSearchTerm;
private final ObservableList<String> patterns;

public CitationKeyPatternsPanel() {
super();
this.patterns = FXCollections.observableArrayList(
CitationKeyPattern.getAllPatterns().stream()
.map(CitationKeyPattern::stringRepresentation)
.toList()
);

ViewLoader.view(this)
.root(this)
Expand All @@ -61,7 +69,7 @@ private void initialize() {
patternColumn.setSortable(true);
patternColumn.setReorderable(false);
patternColumn.setCellValueFactory(cellData -> cellData.getValue().pattern());
patternColumn.setCellFactory(TextFieldTableCell.forTableColumn());
patternColumn.setCellFactory(_ -> new CitationKeyPatternSuggestionCell(patterns));
patternColumn.setEditable(true);
patternColumn.setOnEditCommit(
(TableColumn.CellEditEvent<CitationKeyPatternsPanelItemModel, String> event) ->
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,93 @@
package org.jabref.logic.citationkeypattern;

import java.lang.reflect.Modifier;
import java.util.Arrays;
import java.util.List;
import java.util.stream.Collectors;

public record CitationKeyPattern(String stringRepresentation) {
public static final CitationKeyPattern NULL_CITATION_KEY_PATTERN = new CitationKeyPattern("");

// region - Author-related field markers
public static final CitationKeyPattern AUTHOR_YEAR = new CitationKeyPattern("[auth]");
public static final CitationKeyPattern AUTHOR_FIRST_FULL = new CitationKeyPattern("[authFirstFull]");
public static final CitationKeyPattern AUTHOR_FORE_INI = new CitationKeyPattern("[authForeIni]");
public static final CitationKeyPattern AUTHOR_ETAL = new CitationKeyPattern("[auth.etal]");
public static final CitationKeyPattern AUTHOR_ET_AL = new CitationKeyPattern("[authEtAl]");
public static final CitationKeyPattern AUTHOR_AUTH_EA = new CitationKeyPattern("[auth.auth.ea]");
public static final CitationKeyPattern AUTHORS = new CitationKeyPattern("[authors]");
public static final CitationKeyPattern AUTHORS_N = new CitationKeyPattern("[authorsN]");
public static final CitationKeyPattern AUTH_INI_N = new CitationKeyPattern("[authIniN]");
public static final CitationKeyPattern AUTH_N = new CitationKeyPattern("[authN]");
public static final CitationKeyPattern AUTH_N_M = new CitationKeyPattern("[authN_M]");
public static final CitationKeyPattern AUTHOR_INI = new CitationKeyPattern("[authorIni]");
public static final CitationKeyPattern AUTH_SHORT = new CitationKeyPattern("[authshort]");
public static final CitationKeyPattern AUTHORS_ALPHA = new CitationKeyPattern("[authorsAlpha]");
public static final CitationKeyPattern AUTHORS_ALPHA_LNI = new CitationKeyPattern("[authorsAlphaLNI]");
public static final CitationKeyPattern AUTHORS_LAST = new CitationKeyPattern("[authorsLast]");
public static final CitationKeyPattern AUTHORS_LAST_FORE_INI = new CitationKeyPattern("[authorsLastForeIni]");
// endregion

// region - Editor-related field markers
public static final CitationKeyPattern EDTR = new CitationKeyPattern("[edtr]");
public static final CitationKeyPattern EDTR_INI_N = new CitationKeyPattern("[edtrIniN]");
public static final CitationKeyPattern EDITORS = new CitationKeyPattern("[editors]");
public static final CitationKeyPattern EDITOR_LAST = new CitationKeyPattern("[editorLast]");
public static final CitationKeyPattern EDITOR_INI = new CitationKeyPattern("[editorIni]");
public static final CitationKeyPattern EDTR_N = new CitationKeyPattern("[edtrN]");
public static final CitationKeyPattern EDTR_N_M = new CitationKeyPattern("[edtrN_M]");
public static final CitationKeyPattern EDTR_EDTR_EA = new CitationKeyPattern("[edtr.edtr.ea]");
public static final CitationKeyPattern EDTRSHORT = new CitationKeyPattern("[edtrshort]");
public static final CitationKeyPattern EDTR_FORE_INI = new CitationKeyPattern("[edtrForeIni]");
public static final CitationKeyPattern EDITOR_LAST_FORE_INI = new CitationKeyPattern("[editorLastForeIni]");
// endregion

// region - Title-related field markers
public static final CitationKeyPattern SHORTTITLE = new CitationKeyPattern("[shorttitle]");
public static final CitationKeyPattern SHORTTITLE_INI = new CitationKeyPattern("[shorttitleINI]");
public static final CitationKeyPattern VERYSHORTTITLE = new CitationKeyPattern("[veryshorttitle]");
public static final CitationKeyPattern CAMEL = new CitationKeyPattern("[camel]");
public static final CitationKeyPattern CAMEL_N = new CitationKeyPattern("[camelN]");
public static final CitationKeyPattern TITLE = new CitationKeyPattern("[title]");
public static final CitationKeyPattern FULLTITLE = new CitationKeyPattern("[fulltitle]");
// endregion

// region - Other field markers
public static final CitationKeyPattern ENTRYTYPE = new CitationKeyPattern("[entrytype]");
public static final CitationKeyPattern FIRSTPAGE = new CitationKeyPattern("[firstpage]");
public static final CitationKeyPattern PAGEPREFIX = new CitationKeyPattern("[pageprefix]");
public static final CitationKeyPattern KEYWORD_N = new CitationKeyPattern("[keywordN]");
public static final CitationKeyPattern KEYWORDS_N = new CitationKeyPattern("[keywordsN]");
public static final CitationKeyPattern LASTPAGE = new CitationKeyPattern("[lastpage]");
public static final CitationKeyPattern SHORTYEAR = new CitationKeyPattern("[shortyear]");
// endregion

// region - Bibentry fields
public static final CitationKeyPattern AUTHOR = new CitationKeyPattern("[AUTHOR]");
public static final CitationKeyPattern DATE = new CitationKeyPattern("[DATE]");
public static final CitationKeyPattern DAY = new CitationKeyPattern("[DAY]");
public static final CitationKeyPattern GROUPS = new CitationKeyPattern("[GROUPS]");
public static final CitationKeyPattern MONTH = new CitationKeyPattern("[MONTH]");
public static final CitationKeyPattern YEAR = new CitationKeyPattern("[YEAR]");
// endregion

public static List<CitationKeyPattern> getAllPatterns() {
return Arrays.stream(CitationKeyPattern.class.getDeclaredFields())
.filter(field -> {
int modifiers = field.getModifiers();
return Modifier.isPublic(modifiers) &&
Modifier.isStatic(modifiers) &&
Modifier.isFinal(modifiers) &&
field.getType() == CitationKeyPattern.class &&
!field.equals(CitationKeyPattern.NULL_CITATION_KEY_PATTERN);
})
.map(field -> {
try {
return (CitationKeyPattern) field.get(null);
} catch (IllegalAccessException e) {
throw new RuntimeException("Could not access field", e);
}
})
.collect(Collectors.toList());
}
}
Loading