Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop testing on 3.8, test on 3.13 #502

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Drop testing on 3.8, test on 3.13 #502

wants to merge 1 commit into from

Conversation

amyreese
Copy link
Member

@amyreese amyreese commented Jan 9, 2025

No description provided.

@amyreese amyreese requested a review from zsol as a code owner January 9, 2025 23:00
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 9, 2025
zsol
zsol approved these changes Jan 10, 2025
View reviewed changes
Copy link
Member

@zsol zsol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some fun failures in 3.13, but otherwise LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zsol zsol zsol approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amyreese @zsol @facebook-github-bot