Add Meziantou.Analyzers (#180)

.editorconfig

@@ -309,3 +309,11 @@ dotnet_diagnostic.CA2000.severity = error               # CA2000: Dispose object
 dotnet_diagnostic.CA1515.severity = none                # CA1515: Consider making public types internal
 dotnet_diagnostic.CA1708.severity = none                # CA1708: Identifiers should differ by more than case
 dotnet_diagnostic.CA1716.severity = none                # CA1716: Identifiers should not match keywords
+
+MA0053.public_class_should_be_sealed = true
+MA0053.exceptions_should_be_sealed = true
+
+dotnet_diagnostic.MA0004.severity = none
+dotnet_diagnostic.MA0048.severity = none
+dotnet_diagnostic.MA0051.severity = none
+dotnet_diagnostic.MA0053.severity = warning

Directory.Packages.props

@@ -35,4 +35,8 @@
 	<PackageVersion Include="Verify.TUnit" Version="28.9.0" />
 	<PackageVersion Include="xunit.v3.assert" Version="1.0.1" />
   </ItemGroup>
+
+  <ItemGroup>
+	<GlobalPackageReference Include="Meziantou.Analyzer" Version="2.0.186" />
+  </ItemGroup>
 </Project>

benchmarks/Benchmark.Behaviors/Benchmark.cs

@@ -77,7 +77,7 @@ public sealed record SomeRequest(Guid Id)
 
 public sealed record SomeResponse(Guid Id);
 
-public class SomeService
+public sealed class SomeService
 {
 	private static readonly SomeResponse s_response = new(Guid.NewGuid());
 

benchmarks/Benchmark.Large/Types.cs

@@ -1,6 +1,7 @@
 using Immediate.Handlers.Shared;
 
 #pragma warning disable IDE0060
+#pragma warning disable MA0022
 
 namespace Immediate.Handlers.Benchmarks;
 

samples/Normal/Behaviors.cs

@@ -7,7 +7,7 @@
 
 namespace Normal;
 
-public class LoggingBehavior<TRequest, TResponse>(ILogger<LoggingBehavior<TRequest, TResponse>> logger)
+public sealed class LoggingBehavior<TRequest, TResponse>(ILogger<LoggingBehavior<TRequest, TResponse>> logger)
 	: Behavior<TRequest, TResponse>
 {
 	public override async ValueTask<TResponse> HandleAsync(TRequest request, CancellationToken cancellationToken)

samples/Normal/GetWeatherForecast.cs

@@ -19,9 +19,9 @@ public static partial class GetWeatherForecast
 		"Scorching",
 	];
 
-	public record Query;
+	public sealed record Query;
 
-	public record Response(DateOnly Date, int TemperatureC, string? Summary)
+	public sealed record Response(DateOnly Date, int TemperatureC, string? Summary)
 	{
 		public int TemperatureF => 32 + (int)(TemperatureC / 0.5556);
 	}

src/Common/ITypeSymbolExtensions.cs

@@ -5,6 +5,25 @@ namespace Immediate.Handlers;
 
 internal static class ITypeSymbolExtensions
 {
+	public static bool IsHandlerAttribute(this ITypeSymbol? typeSymbol) =>
+		typeSymbol is
+		{
+			Name: "HandlerAttribute",
+			ContainingNamespace:
+			{
+				Name: "Shared",
+				ContainingNamespace:
+				{
+					Name: "Handlers",
+					ContainingNamespace:
+					{
+						Name: "Immediate",
+						ContainingNamespace.IsGlobalNamespace: true,
+					},
+				},
+			},
+		};
+
 	public static bool IsBehavior2(this ITypeSymbol typeSymbol) =>
 		typeSymbol is
 		{

src/Immediate.Handlers.Analyzers/HandlerClassAnalyzer.cs

@@ -117,7 +117,7 @@ private static void AnalyzeSymbol(SymbolAnalysisContext context)
 
 		if (!namedTypeSymbol
 				.GetAttributes()
-				.Any(x => x.AttributeClass?.ToString() == "Immediate.Handlers.Shared.HandlerAttribute")
+				.Any(x => x.AttributeClass.IsHandlerAttribute())
 		)
 		{
 			return;
@@ -178,10 +178,8 @@ private static void AnalyzeSymbol(SymbolAnalysisContext context)
 			case [var methodSymbol]:
 			{
 				token.ThrowIfCancellationRequested();
-				if (methodSymbol.ReturnType is INamedTypeSymbol returnTypeSymbol
-					&& returnTypeSymbol.ConstructedFrom.ToString() is not (
-						"System.Threading.Tasks.ValueTask<TResult>"
-						or "System.Threading.Tasks.ValueTask")
+				if (methodSymbol.ReturnType is INamedTypeSymbol { ConstructedFrom: { } from }
+					&& !from.IsValueTask() && !from.IsValueTask1()
 				)
 				{
 					context.ReportDiagnostic(

src/Immediate.Handlers.CodeFixes/HandlerMethodMustExistCodeFixProvider.cs

@@ -11,7 +11,7 @@
 namespace Immediate.Handlers.CodeFixes;
 
 [ExportCodeFixProvider(LanguageNames.CSharp)]
-public class HandlerMethodMustExistCodeFixProvider : CodeFixProvider
+public sealed class HandlerMethodMustExistCodeFixProvider : CodeFixProvider
 {
 	public override ImmutableArray<string> FixableDiagnosticIds { get; } =
 		ImmutableArray.Create([DiagnosticIds.IHR0001HandlerMethodMustExist]);

src/Immediate.Handlers.Generators/ImmediateHandlersGenerator.Models.cs

@@ -4,7 +4,7 @@
 
 namespace Immediate.Handlers.Generators.ImmediateHandlers;
 
-public partial class ImmediateHandlersGenerator
+public sealed partial class ImmediateHandlersGenerator
 {
 	[ExcludeFromCodeCoverage]
 	private sealed record Behavior

src/Immediate.Handlers.Generators/ImmediateHandlersGenerator.TransformBehaviors.cs

@@ -2,7 +2,7 @@
 
 namespace Immediate.Handlers.Generators.ImmediateHandlers;
 
-public partial class ImmediateHandlersGenerator
+public sealed partial class ImmediateHandlersGenerator
 {
 	private static EquatableReadOnlyList<Behavior?> TransformBehaviors(
 		GeneratorAttributeSyntaxContext context,
@@ -132,7 +132,7 @@ private static (bool Valid, string? Constraint) GetConstraintType(ITypeParameter
 					ITypeParameterSymbol s,
 				]
 			}
-			&& s.Name == parameter.Name
+			&& s.Name.Equals(parameter.Name, StringComparison.OrdinalIgnoreCase)
 		)
 		{
 			displayString = displayString.Replace(parameter.Name, "_TRequest_");

src/Immediate.Handlers.Generators/ImmediateHandlersGenerator.TransformHandler.cs

@@ -4,7 +4,7 @@
 
 namespace Immediate.Handlers.Generators.ImmediateHandlers;
 
-public partial class ImmediateHandlersGenerator
+public sealed partial class ImmediateHandlersGenerator
 {
 	private static Handler? TransformHandler(
 		GeneratorAttributeSyntaxContext context,
@@ -111,7 +111,7 @@ CancellationToken cancellationToken
 		return new()
 		{
 			Name = name,
-			Implements = implements.Distinct().ToEquatableReadOnlyList(),
+			Implements = implements.Distinct(StringComparer.Ordinal).ToEquatableReadOnlyList(),
 		};
 	}
 

src/Immediate.Handlers.Generators/ImmediateHandlersGenerator.cs

@@ -7,7 +7,7 @@
 namespace Immediate.Handlers.Generators.ImmediateHandlers;
 
 [Generator]
-public partial class ImmediateHandlersGenerator : IIncrementalGenerator
+public sealed partial class ImmediateHandlersGenerator : IIncrementalGenerator
 {
 	public void Initialize(IncrementalGeneratorInitializationContext context)
 	{
@@ -191,8 +191,10 @@ Template template
 			GenericType responseType,
 			IEnumerable<Behavior?> enumerable) =>
 		enumerable
-			.Where(b => b is null || ValidateType(b.RequestType, requestType))
-			.Where(b => b is null || ValidateType(b.ResponseType, responseType))
+			.Where(b =>
+				(b is null || ValidateType(b.RequestType, requestType))
+				&& (b is null || ValidateType(b.ResponseType, responseType))
+			)
 			.ToList();
 
 	private sealed record RenderBehavior
@@ -203,7 +205,7 @@ private sealed record RenderBehavior
 
 	private static List<RenderBehavior> BuildRenderBehaviors(List<Behavior?> pipelineBehaviors)
 	{
-		var typesCount = new Dictionary<string, int>()
+		var typesCount = new Dictionary<string, int>(StringComparer.Ordinal)
 		{
 			["HandleBehavior"] = 1,
 		};
@@ -224,7 +226,7 @@ string GetVariableNameSuffix(string typeName)
 				NonGenericTypeName = b!.NonGenericTypeName,
 				VariableName = b.Name[0..1].ToLowerInvariant()
 					+ b.Name[1..]
-					+ GetVariableNameSuffix(b.Name)
+					+ GetVariableNameSuffix(b.Name),
 			})
 			.ToList();
 #pragma warning restore CA1308 // Normalize strings to uppercase
@@ -234,7 +236,7 @@ string GetVariableNameSuffix(string typeName)
 
 	private static bool ValidateType(string? type, GenericType implementedTypes) =>
 		type is null
-		|| implementedTypes.Implements.Contains(type.Replace("_TRequest_", implementedTypes.Name));
+		|| implementedTypes.Implements.Contains(type.Replace("_TRequest_", implementedTypes.Name), StringComparer.Ordinal);
 
 	private static Template GetTemplate(string name)
 	{

tests/Immediate.Handlers.FunctionalTests/Behavior/Constraints/Tests.Base.cs

@@ -27,12 +27,12 @@ private static IServiceCollection ConfigureBehaviors(IServiceCollection services
 	}
 }
 
-public class BehaviorWalker
+public sealed class BehaviorWalker
 {
 	public IList<string> BehaviorsRan { get; init; } = [];
 }
 
-public class BehaviorA<TRequest, TResponse>(BehaviorWalker walker) : Behavior<TRequest, TResponse> where TRequest : A
+public sealed class BehaviorA<TRequest, TResponse>(BehaviorWalker walker) : Behavior<TRequest, TResponse> where TRequest : A
 {
 	public override async ValueTask<TResponse> HandleAsync(TRequest request, CancellationToken cancellationToken)
 	{
@@ -41,7 +41,7 @@ public override async ValueTask<TResponse> HandleAsync(TRequest request, Cancell
 	}
 }
 
-public class BehaviorB<TRequest, TResponse>(BehaviorWalker walker) : Behavior<TRequest, TResponse> where TRequest : B
+public sealed class BehaviorB<TRequest, TResponse>(BehaviorWalker walker) : Behavior<TRequest, TResponse> where TRequest : B
 {
 	public override async ValueTask<TResponse> HandleAsync(TRequest request, CancellationToken cancellationToken)
 	{
@@ -50,7 +50,7 @@ public override async ValueTask<TResponse> HandleAsync(TRequest request, Cancell
 	}
 }
 
-public class BehaviorC<TRequest, TResponse>(BehaviorWalker walker) : Behavior<TRequest, TResponse> where TRequest : C
+public sealed class BehaviorC<TRequest, TResponse>(BehaviorWalker walker) : Behavior<TRequest, TResponse> where TRequest : C
 {
 	public override async ValueTask<TResponse> HandleAsync(TRequest request, CancellationToken cancellationToken)
 	{
@@ -59,7 +59,7 @@ public override async ValueTask<TResponse> HandleAsync(TRequest request, Cancell
 	}
 }
 
-public class BehaviorD<TRequest, TResponse>(BehaviorWalker walker) : Behavior<TRequest, TResponse> where TRequest : D
+public sealed class BehaviorD<TRequest, TResponse>(BehaviorWalker walker) : Behavior<TRequest, TResponse> where TRequest : D
 {
 	public override async ValueTask<TResponse> HandleAsync(TRequest request, CancellationToken cancellationToken)
 	{

tests/Immediate.Handlers.FunctionalTests/HandlerAbstraction/HandlerAbstractionTests.cs

@@ -15,7 +15,7 @@ private static ValueTask<int> HandleAsync(
 	}
 }
 
-public class HandlerAbstractionTests
+public sealed class HandlerAbstractionTests
 {
 	[Test]
 	public async Task NoBehaviorShouldReturnExpectedResponseForAbstraction()

tests/Immediate.Handlers.FunctionalTests/MultipleBehaviors/MultipleBehaviorsTests.cs

@@ -2,7 +2,7 @@
 
 namespace Immediate.Handlers.FunctionalTests.MultipleBehaviors;
 
-public class Behavior1<TRequest, TResponse> : Behavior<TRequest, TResponse>
+public sealed class Behavior1<TRequest, TResponse> : Behavior<TRequest, TResponse>
 	where TRequest : List<string>
 {
 	public override async ValueTask<TResponse> HandleAsync(TRequest request, CancellationToken cancellationToken)
@@ -17,7 +17,7 @@ public override async ValueTask<TResponse> HandleAsync(TRequest request, Cancell
 	}
 }
 
-public class Behavior2<TRequest, TResponse> : Behavior<TRequest, TResponse>
+public sealed class Behavior2<TRequest, TResponse> : Behavior<TRequest, TResponse>
 	where TRequest : List<string>
 {
 	public override async ValueTask<TResponse> HandleAsync(TRequest request, CancellationToken cancellationToken)
@@ -40,7 +40,7 @@ public override async ValueTask<TResponse> HandleAsync(TRequest request, Cancell
 )]
 public static partial class MultipleBehaviorHandler
 {
-	public class Query : List<string>;
+	public sealed class Query : List<string>;
 
 	private static async ValueTask<int> HandleAsync(Query query, CancellationToken cancellationToken)
 	{

tests/Immediate.Handlers.FunctionalTests/NoBehaviors/ParameterizedTests.cs

@@ -19,7 +19,7 @@ private static ValueTask<int> Handle(
 
 public record AddendProvider(int Addend);
 
-public class ParameterizedTests
+public sealed class ParameterizedTests
 {
 	[Test]
 	public async Task NoBehaviorShouldReturnExpectedResponse()

tests/Immediate.Handlers.FunctionalTests/NoBehaviors/ParameterlessTests.cs

@@ -28,7 +28,7 @@ Query query
 	}
 }
 
-public class ParameterlessTests
+public sealed class ParameterlessTests
 {
 	[Test]
 	public async Task NoBehaviorShouldReturnExpectedResponse()

tests/Immediate.Handlers.Tests/AnalyzerTests/BehaviorAnalyzerTests/Tests.BehaviorTypeDoesNotUseUnboundedReference.cs

@@ -4,7 +4,7 @@
 namespace Immediate.Handlers.Tests.AnalyzerTests.BehaviorAnalyzerTests;
 
 [System.Diagnostics.CodeAnalysis.SuppressMessage("Naming", "CA1724:Type names should not match namespaces", Justification = "Not being consumed by other code")]
-public partial class Tests
+public sealed partial class Tests
 {
 	[Test]
 	public async Task BehaviorTypeDoesNotUseUnboundedReference_Alerts() =>

tests/Immediate.Handlers.Tests/AnalyzerTests/BehaviorAnalyzerTests/Tests.BehaviorTypeIsValid.cs

@@ -4,7 +4,7 @@
 namespace Immediate.Handlers.Tests.AnalyzerTests.BehaviorAnalyzerTests;
 
 [System.Diagnostics.CodeAnalysis.SuppressMessage("Naming", "CA1724:Type names should not match namespaces", Justification = "Not being consumed by other code")]
-public partial class Tests
+public sealed partial class Tests
 {
 	[Test]
 	public async Task BehaviorTypeIsValid_DoesNotAlert() =>

tests/Immediate.Handlers.Tests/AnalyzerTests/HandlerClassAnalyzerTests/Tests.HandlerClassNested.cs

@@ -3,7 +3,7 @@
 
 namespace Immediate.Handlers.Tests.AnalyzerTests.HandlerClassAnalyzerTests;
 
-public partial class Tests
+public sealed partial class Tests
 {
 	[Test]
 	public async Task HandlerClassNested_DoesAlert() =>

tests/Immediate.Handlers.Tests/CodeFixTests/Tests.HandleMethodDoesNotExist.cs

@@ -5,7 +5,7 @@
 namespace Immediate.Handlers.Tests.CodeFixTests;
 
 [System.Diagnostics.CodeAnalysis.SuppressMessage("Naming", "CA1724:Type names should not match namespaces", Justification = "Not being consumed by other code")]
-public partial class Tests
+public sealed partial class Tests
 {
 	[Test]
 	public async Task HandleMethodDoesNotExist() =>

tests/Immediate.Handlers.Tests/GeneratorTests/BehaviorTests.cs

@@ -79,14 +79,14 @@ public interface ILogger<T>;
 					DriverReferenceAssemblies.Msdi =>
 						["Immediate.Handlers.Generators/Immediate.Handlers.Generators.ImmediateHandlers.ImmediateHandlersGenerator/IH.ServiceCollectionExtensions.g.cs"],
 
-					_ => throw new UnreachableException(),
+					DriverReferenceAssemblies.None or _ => throw new UnreachableException(),
 				},
 			],
-			result.GeneratedTrees.Select(t => t.FilePath.Replace("\\", "/", StringComparison.Ordinal))
+			result.GeneratedTrees.Select(t => t.FilePath.Replace('\\', '/'))
 		);
 
 		_ = await Verify(result)
-			.UseParameters(string.Join("_", assemblies));
+			.UseParameters(string.Join('_', assemblies));
 	}
 
 	[Test]
@@ -228,14 +228,14 @@ public interface ILogger<T>;
 					DriverReferenceAssemblies.Msdi =>
 						["Immediate.Handlers.Generators/Immediate.Handlers.Generators.ImmediateHandlers.ImmediateHandlersGenerator/IH.ServiceCollectionExtensions.g.cs"],
 
-					_ => throw new UnreachableException(),
+					DriverReferenceAssemblies.None or _ => throw new UnreachableException(),
 				},
 			],
-			result.GeneratedTrees.Select(t => t.FilePath.Replace("\\", "/", StringComparison.Ordinal))
+			result.GeneratedTrees.Select(t => t.FilePath.Replace('\\', '/'))
 		);
 
 		_ = await Verify(result)
-			.UseParameters(string.Join("_", assemblies));
+			.UseParameters(string.Join('_', assemblies));
 	}
 
 	[Test]
@@ -297,13 +297,13 @@ CancellationToken __
 					DriverReferenceAssemblies.Msdi =>
 						["Immediate.Handlers.Generators/Immediate.Handlers.Generators.ImmediateHandlers.ImmediateHandlersGenerator/IH.ServiceCollectionExtensions.g.cs"],
 
-					_ => throw new UnreachableException(),
+					DriverReferenceAssemblies.None or _ => throw new UnreachableException(),
 				},
 			],
-			result.GeneratedTrees.Select(t => t.FilePath.Replace("\\", "/", StringComparison.Ordinal))
+			result.GeneratedTrees.Select(t => t.FilePath.Replace('\\', '/'))
 		);
 
 		_ = await Verify(result)
-			.UseParameters(string.Join("_", assemblies));
+			.UseParameters(string.Join('_', assemblies));
 	}
 }