-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows linux translation #89
Windows linux translation #89
Conversation
update from -matte to -alpha Note, the resultant images look different than what I get when I run this command.
Thanks for your contribution. I like this idea but I haven't had time yet to properly test/review this. Can you resolve the conflicts in this pull request? |
Sure thing. Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making these changes. Left some review comments.
Made the suggested changes. I left two comments on changes, 1 where I'm not sure what you meant by the comment, and the other where I didn't think using a query selector would be beneficial, but am open to being convinced. |
Updated to a query selector for the samp child. |
Removed sourcemappingurl from the bootstrap min.js and remove eol echo into the magick js php. |
Looks like there are still some merging issue with this PR? |
Interesting it says there arent any merge conflicts here. ill try to merge locally again tonight. |
Thanks, your local |
Feel free to reach out by email if you need any help. |
I've updated and merged, without issue, and see no conflicts still. Not sure what to look at next. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found some minor other things. Almost ready to merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this!
I made some tweaks to your script. I tried to put this in small commits so it will be easier for you to see what I did. |
This is my first submission in an attempt to update the Image Magick docs to help out windows users by doing auto conversion between linux cli syntax and windows.
It is heavily inspired by https://imagemagick.org/Usage/windows/ which contains a script to do just this.
I have not 1 to 1 implemented the script due to some complexities I'm not sure were fully covered, such as inline comments, but did an additional fix of ensuring spaces on either side of parens which is a requirement of dos.
Here is a rundown:
<pre>
tags with the "cli" class and then copies the contents 2 times.<pre "*"><samp>magick
<code>
box.$ magick ...
were missed, but this was to avoid mangling their return results.Here is a gif showing what the system looks like in practice.

I did spot check several image magick commands using both the dos commandline (windows 10) and .bat files
I had to fix the very first command which had an errant
")
at the end.If this goes well I would like to bring this logic (modified of course) to the usage examples, which will require a bit more effort but I think be very valuable.