Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add handling a new error code - 91 #2935

Closed
wants to merge 1 commit into from

Conversation

dimonleksin
Copy link

Go version 1.20
Kafka version 3.7.1(latest)
IF call DescribeUserScramCredentials with non-existent user - kafka returned error code 91 and description "Attempt to describe a user credential that does not exist: "
In a Kafka Protocol Specification this not written, but in my practice this true.

ErrUnstableOffsetCommit KError = 88 // Errors.UNSTABLE_OFFSET_COMMIT
ErrThrottlingQuotaExceeded KError = 89 // Errors.THROTTLING_QUOTA_EXCEEDED
ErrProducerFenced KError = 90 // Errors.PRODUCER_FENCED
ErrDescribeUserScramCredentialNotExist KError = 91 // User not founded with describe users
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, code named by "resource not found", but used this error only with users. So, i can rename this in next commit?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whatever this name is when merged becomes the name that it has to be to keep from now until we can make a breaking change.

So, ideally, we want this error to be descriptive but also generic enough to cover all of its usage. And breaking with the common format and concurrence with Errors.RESOURCE_NOT_FOUND would violate the principle least astonishment.

Copy link

Thank you for your contribution! However, this pull request has not had any activity in the past 90 days and will be closed in 30 days if no updates occur.
If you believe the changes are still valid then please verify your branch has no conflicts with main and rebase if needed. If you are awaiting a (re-)review then please let us know.

@github-actions github-actions bot added the stale Issues and pull requests without any recent activity label Oct 14, 2024
@github-actions github-actions bot closed this Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Issues and pull requests without any recent activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants