Rewrite from /bin/bash to pure /bin/sh #930
Closed
+200
−171
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Advantages:
Also solves the weird bootstrap problem of
/bin/bash <install brew> && brew install bash
. Whether system Bash [or system Ruby for that matter] or a locally installed one is installed, in all cases it could be handled cleanly by using pure/bin/sh
.PS: Tell me if you want this and I'll finish the PR