Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite from /bin/bash to pure /bin/sh #930

Closed
wants to merge 1 commit into from

Conversation

SamuelMarks
Copy link

Advantages:

  • Futureproofed
  • No need for unfamiliar /bin/bash syntax for new users (they can just launch it in Bash, Zsh, Dash, or whatever else)
  • Paves the way to port to new platforms (e.g., FreeBSD, busybox, MinGW, &etc.)

Also solves the weird bootstrap problem of /bin/bash <install brew> && brew install bash. Whether system Bash [or system Ruby for that matter] or a locally installed one is installed, in all cases it could be handled cleanly by using pure /bin/sh.

PS: Tell me if you want this and I'll finish the PR

@SMillerDev
Copy link
Member

I don't think we support any platforms that don't ship some version of bash and I don't think it's a goal to support those either.
Seeing how much this complicates the already complicated script I'm not really in favour.

@MikeMcQuaid
Copy link
Member

Passing on this, sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants