Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mas: strip unprintable characters from app names #1570

Merged
merged 2 commits into from
Jan 22, 2025
Merged

mas: strip unprintable characters from app names #1570

merged 2 commits into from
Jan 22, 2025

Conversation

EricFromCanada
Copy link
Member

Fixes #1569 by removing unprintable characters from app names before generating the Brewfile.

jacobbednarz
jacobbednarz requested changes Jan 21, 2025
View reviewed changes
Copy link
Member

@jacobbednarz jacobbednarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we add a test for this one to confirm we're solving the issue?

MikeMcQuaid
MikeMcQuaid approved these changes Jan 22, 2025
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thanks @EricFromCanada!

@MikeMcQuaid MikeMcQuaid merged commit f5acb38 into master Jan 22, 2025
5 checks passed
@MikeMcQuaid MikeMcQuaid deleted the strip-unprintable branch January 22, 2025 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobbednarz jacobbednarz jacobbednarz approved these changes

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove unprintable characters from App Store apps in Brewfile
3 participants
@EricFromCanada @MikeMcQuaid @jacobbednarz