Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

utils/curl: fix user_agent types #19172

Merged
merged 1 commit into from
Jan 30, 2025
Merged

utils/curl: fix user_agent types #19172

merged 1 commit into from
Jan 30, 2025

Conversation

zyoshoka
Copy link
Contributor

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

@zyoshoka zyoshoka mentioned this pull request Jan 30, 2025
Merged
@daeho-ro daeho-ro requested a review from samford January 30, 2025 07:20
MikeMcQuaid
MikeMcQuaid reviewed Jan 30, 2025
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Don't think we need NilClass here?

Library/Homebrew/utils/curl.rb Outdated Show resolved Hide resolved
Library/Homebrew/utils/curl.rb Outdated Show resolved Hide resolved
@zyoshoka
utils/curl: fix user_agent types
9e93b52 
`user_agent` should also allow strings and nil.
@zyoshoka zyoshoka force-pushed the utils/curl/fix-user-agent-type branch from b056393 to 9e93b52 Compare January 30, 2025 10:21
samford
samford approved these changes Jan 30, 2025
View reviewed changes
Copy link
Member

@samford samford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this!

@samford samford added this pull request to the merge queue Jan 30, 2025
Merged via the queue into Homebrew:master with commit c757219 Jan 30, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid left review comments

@samford samford samford approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zyoshoka @MikeMcQuaid @samford