Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement fixes and comments for DisableComment rubocop #19168

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Library/Homebrew/cask/artifact/abstract_artifact.rb
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ def <=>(other)
return unless other.class < AbstractArtifact
return 0 if instance_of?(other.class)

# TODO: Replace class var @@sort_order with a class instance var.
@@sort_order ||= [ # rubocop:disable Style/ClassVars
PreflightBlock,
# The `uninstall` stanza should be run first, as it may
Expand Down
1 change: 1 addition & 0 deletions Library/Homebrew/download_strategy.rb
Original file line number Diff line number Diff line change
Expand Up @@ -703,6 +703,7 @@ def stage

# Strategy for extracting local binary packages.
class LocalBottleDownloadStrategy < AbstractFileDownloadStrategy
# TODO: Call `super` here
def initialize(path) # rubocop:disable Lint/MissingSuper
@cached_location = path
extend Pourable
Expand Down
6 changes: 2 additions & 4 deletions Library/Homebrew/lazy_object.rb
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,9 @@ def initialize(&callable)
end

def __getobj__
# rubocop:disable Naming/MemoizedInstanceVariableName
return @__delegate__ if defined?(@__delegate__)
return @__getobj__ if defined?(@__getobj__)

@__delegate__ = @__callable__.call
# rubocop:enable Naming/MemoizedInstanceVariableName
@__getobj__ = @__callable__.call
end
private :__getobj__

Expand Down
1 change: 1 addition & 0 deletions Library/Homebrew/utils.rb
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ def self.system(cmd, *args, **options)
_system(cmd, *args, **options)
end

# `Module` and `Regexp` are global variables used as types here so they don't need to be imported
# rubocop:disable Style/GlobalVars
sig { params(the_module: Module, pattern: Regexp).void }
def self.inject_dump_stats!(the_module, pattern)
Expand Down
Loading