Use environment variables consistently #19153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeMcQuaid
added a commit
to Homebrew/homebrew-services
that referenced
this pull request
Jan 27, 2025
This is consistent with e.g. Homebrew/brew#19153
MikeMcQuaid
added a commit
to Homebrew/homebrew-command-not-found
that referenced
this pull request
Jan 27, 2025
This is consistent with e.g. Homebrew/brew#19153
SMillerDev
approved these changes
Jan 27, 2025
MikeMcQuaid
force-pushed
the
env_var_consistency
branch
from
b2cf643 to
cf818b1
Compare
MikeMcQuaid
changed the title
SMillerDev
approved these changes
Jan 27, 2025
- use e.g. `$HOMEBREW_*` for cases where only the environment variable
is the entire backtick-quoted string
- use e.g. `${HOMEBREW_*}` for cases where the environment variable is
part of a backtick-quoted string to make clear what parts are variable
and what parts are not
- use `export HOMEBREW_*=...` for cases where we're talking about
setting the environment variable (because it likely needs to be
exported to work how they want)
Inspired by Homebrew/homebrew-bundle#1579 making
similar changes for Homebrew/homebrew-bundle.
MikeMcQuaid
force-pushed
the
env_var_consistency
branch
from
cf818b1 to
bbf5a9f
Compare
EricFromCanada
approved these changes
Jan 27, 2025
Bo98
reviewed
Jan 27, 2025
| vst_plugindir: "~/Library/Audio/Plug-Ins/VST", | ||
| vst3_plugindir: "~/Library/Audio/Plug-Ins/VST3", | ||
| screen_saverdir: "~/Library/Screen Savers", | ||
| colorpickerdir: "${HOME}/Library/ColorPickers", |
There was a problem hiding this comment.
Does Pathname("${HOME}").expand_path work?
There was a problem hiding this comment.
@Bo98 No. I'll revert the $HOME changes.
This was referenced Jan 27, 2025
MikeMcQuaid
added a commit
to Homebrew/homebrew-bundle
that referenced
this pull request
Jan 27, 2025
Partial revert of #1579 See Homebrew/brew#19153 (comment)
This was referenced Jan 27, 2025
MikeMcQuaid
added a commit
that referenced
this pull request
Jan 27, 2025
Partial revert of #19153 See #19153 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$HOMEBREW_*for cases where only the environment variable is the entire backtick-quoted string${HOMEBREW_*}for cases where the environment variable is part of a backtick-quoted string to make clear what parts are variable and what parts are notexport HOMEBREW_*=...for cases where we're talking about setting the environment variable (because it likely needs to be exported to work how they want)Inspired by Homebrew/homebrew-bundle#1579 making similar changes for Homebrew/homebrew-bundle