Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: refactor content import #732

Open
wants to merge 127 commits into
base: main
Choose a base branch
from
Open

fix: refactor content import #732

wants to merge 127 commits into from
+212 −341

Conversation

Emnaghz
Copy link
Collaborator

@Emnaghz Emnaghz commented Feb 9, 2025 •
edited
Loading

Motivation

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change:

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added unit tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@Emnaghz Emnaghz linked an issue Feb 9, 2025 that may be closed by this pull request
🤔 [Enhancement] - Content Import #537
Open
@marrouchi
Copy link
Contributor

marrouchi commented Feb 10, 2025 •
edited
Loading

@Emnaghz Thanks, can you please rebase your PR, also if you could plz update the PR description?

abdou6666
abdou6666 reviewed Feb 10, 2025
View reviewed changes
api/src/cms/controllers/content.controller.ts
},
@CsrfCheck(true)
@Post('import')
@UseInterceptors(FileInterceptor('file'))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we set a limit for file size ? if not we should stream it and pipe it

IkbelTalebHssan
IkbelTalebHssan reviewed Feb 10, 2025
View reviewed changes
Copy link
Collaborator

@IkbelTalebHssan IkbelTalebHssan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Emnaghz
Nice work 👏
Left you some minor comments

api/src/cms/services/content.service.ts Outdated Show resolved Hide resolved
api/src/cms/services/content.service.ts Outdated Show resolved Hide resolved
marrouchi and others added 20 commits February 12, 2025 14:35
@marrouchi @Emnaghz
refactor: dialog system (partial)
c4a82d7
@yassinedorbozgithub @Emnaghz
feat(frontend): add useDialog
26161ae
@yassinedorbozgithub @Emnaghz
refactor(frontend): update categories pages
f5d01be
@yassinedorbozgithub @Emnaghz
refactor(frontend): update visual editor categories pages
a5d6092
@yassinedorbozgithub @Emnaghz
fix(frontend): apply feedback updates
89a85e2
@yassinedorbozgithub @Emnaghz
fix(frontend): remove unused comments
453f0d9
@yassinedorbozgithub @Emnaghz
fix(frontend): add retrocompatibility for dialog close button
8cc57d0
@yassinedorbozgithub @Emnaghz
fix(frontend): update dialog close button
8608228
@yassinedorbozgithub @Emnaghz
fix(frontend): include minor updates
d07641b
@yassinedorbozgithub @Emnaghz
fix(frontend): add input error attribute
74b103e
@yassinedorbozgithub @Emnaghz
fix(frontend): apply feedback updates
e6c1b07
@yassinedorbozgithub @Emnaghz
fix(frontend): apply feedback updates
d9354ea
@yassinedorbozgithub @Emnaghz
fix(frontend): update categoryForm to use mutate
adf2d1f
@yassinedorbozgithub @Emnaghz
fix(frontend): remove submitAsync function
7479ba2
@yassinedorbozgithub @Emnaghz
fix(frontend): include minor changes
de022cc
@yassinedorbozgithub @Emnaghz
fix(frontend): update variable name
8770c62
@yassinedorbozgithub @Emnaghz
fix(frontend): include minor changes
cf0bd4b
@yassinedorbozgithub @Emnaghz
fix(frontend): add disabled attribute for category delete button
c6fe097
@yassinedorbozgithub @Emnaghz
fix(frontend): add feedback updates
17cba93
@yassinedorbozgithub @Emnaghz
fix(frontend): add dialog extra props
cce1043
abdou6666 and others added 30 commits February 12, 2025 14:44
@abdou6666 @Emnaghz
fix: attachment validation bug
06453cb
@abdou6666 @Emnaghz
fix: apply feedback
778e466
@abdou6666 @Emnaghz
fix: apply feedback
d39f11a
@abdou6666 @Emnaghz
fix: remove if plugin in msg check
b2feffc
@abdou6666 @Emnaghz
fix: pluginNameSchema typing
a37f3ec
@abdou6666 @Emnaghz
fix: unnecessary type casting
3fd319b
@abdou6666 @Emnaghz
fix: refactor blockMessageSchema
2b5a4b3
@abdou6666 @Emnaghz
fix: apply feedback
c8fa799
@abdou6666 @Emnaghz
fix: remove casting
5ed6012
@abdou6666 @Emnaghz
fix: typing & remove type assertion
46b43ab
@abdou6666 @Emnaghz
fix: remove type assertion
58f9afe
@abdou6666 @Emnaghz
fix: remove duplicate copyright
a5619dc
@yassinedorbozgithub @Emnaghz
refactor(frontend): update contentType dialogs
712eba0
@yassinedorbozgithub @Emnaghz
refactor(frontend): update Attachment and AttachmentThumbnail dialogs
c150f95
@yassinedorbozgithub @Emnaghz
refactor(frontend): update AttachmentViewer dialog
4bee9ed
@yassinedorbozgithub @Emnaghz
refactor(frontend): update BlockEdit and BlockMove dialogs
6490b75
@yassinedorbozgithub @Emnaghz
refactor(frontend): remove old resources
1ff915d
@yassinedorbozgithub @Emnaghz
refactor(frontend): resolve TS errors
bead904
@yassinedorbozgithub @Emnaghz
fix: apply feedback updates
6b87183
@yassinedorbozgithub @Emnaghz
fix(frontend): resolve superposed edit dialogs
6d5acdf
@yassinedorbozgithub @Emnaghz
refactor(frontend): optimize useDialogs logic
f8ce1b2
@yassinedorbozgithub @Emnaghz
refactor(frontend): resolve TS errors
231cff4
@yassinedorbozgithub @Emnaghz
fix(frontend): apply feedback updates
cd2ee77
@abdou6666 @Emnaghz
fix: use pages router instead of app router
6b35db2
@abdou6666 @Emnaghz
fix: bug when we have dynamic route default redirection to '/'
3f82a2f
@abdou6666 @Emnaghz
fix: redirection to dynamic path
daec095
@abdou6666 @Emnaghz
fix: refactor
33c1014
@abdou6666 @Emnaghz
feat: refactor zod validation
54949a6
@abdou6666 @Emnaghz
fix: validMessageTextSchema bug
680f8ca
@Emnaghz
fix: add requested changes
3416d93
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abdou6666 abdou6666 abdou6666 requested changes

@IkbelTalebHssan IkbelTalebHssan IkbelTalebHssan left review comments

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🤔 [Enhancement] - Content Import
5 participants
@Emnaghz @marrouchi @abdou6666 @IkbelTalebHssan @yassinedorbozgithub