Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix base64 output for linkedin icons and sed regex #1

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

alexbraga
Copy link

The base64 outputs for both LinkedIn icons (dim and white) in the 'Removed Icons' section of the markdown.md file didn't match the correct values. Also, the regex for the sed command to add the SVG attribute fill="#ffffff" didn't include the necessary whitespace at the beginning of the replacement string. Another small fix was to add the 'global' flag to the regex, to handle logos with multiple paths, like the Java one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant