-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tech Report: Lighthouse audit pass rates #38
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.
Files not reviewed (1)
- definitions/output/reports/cwv_tech_categories.js: Evaluated as low risk
Comments suppressed due to low confidence (1)
definitions/output/reports/cwv_tech_technologies.js:13
- Inconsistent naming of 'technology'. It should be consistently referred to as either 'tech.technology' or 'technology' throughout the file.
tech.technology
a677a6d
to
1200d11
Compare
@rviscomi do we need retrospective data? Since when? |
@rviscomi did I get this one correct? |
Sorry I'm fuzzy on the context for this PR. This counts the number of sites whose LH category score >= 90? That's not something we currently have in Looker Studio, so it's not a feature parity thing, and AFAIK it's not something we discussed for the new dashboard. We DO have a related discussion about highlighting technologies' areas for improvement. For that we could be highlighting the pass rates of individual audits, grouped by category. Or "here are the top ways LH says you can improve this technology's performance score". I believe you're exploring that in #49. Eventually I would love to expand that to more insights powered by HA custom metrics or other manual analysis, like the % of sites that use |
That's exactly what I thought - I got lost in lighthouse JSON. This one is the score pass rates, and we discard this - correct? |
Sorry, yeah I don't think we need category-level pass rates (median score is fine) |
Lighthouse audit pass rates:
Updated
/lighthouse
response:Required schema adjustments