Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: remove ubuntu 20.04 runners #5545

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

ci: remove ubuntu 20.04 runners #5545

wants to merge 5 commits into from
+136 −70

Conversation

sunng87
Copy link
Member

@sunng87 sunng87 commented Feb 14, 2025 •
edited
Loading

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

Fixes #5537

What's changed and what's your intention?

  • changed ubuntu 20.04 to latest when it's possible
  • use ubuntu 22.04 for binary building and release

PR Checklist

Please convert it to a draft if some of the following conditions are not met.

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.
  • API changes are backward compatible.
  • Schema or data changes are backward compatible.

@sunng87 sunng87 requested a review from a team as a code owner February 14, 2025 20:02
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Feb 14, 2025
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 14, 2025

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@sunng87 sunng87 requested a review from waynexia February 14, 2025 22:12
evenyag
evenyag reviewed Feb 17, 2025
View reviewed changes
.github/workflows/dev-build.yml
@@ -83,7 +83,7 @@ jobs:
allocate-runners:
name: Allocate runners
if: ${{ github.repository == 'GreptimeTeam/greptimedb' }}
runs-on: ubuntu-20.04
runs-on: ubuntu-latest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to specify the ubuntu version here? @zyy17

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is only used for allocate actual builders I think

zyy17
zyy17 reviewed Feb 17, 2025
View reviewed changes
docker/dev-builder/ubuntu/Dockerfile
@@ -1,4 +1,4 @@
FROM ubuntu:20.04
FROM ubuntu:22.04
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to upgrade the base image for dev-builder? The change may upgrade the glibc version.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the dev-build base image should be upgrade first by: #5554

use the ubuntu-22.04 image to build the dev-build image, and then use the latest dev-build image tag to modify here: https://github.com/GreptimeTeam/greptimedb/blob/main/Makefile#L11

Copy link
Member Author

@sunng87 sunng87 Feb 17, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

20.04 is reaching its end of life in May. The apt repository will be offline at that time.

@daviderli614 daviderli614 mentioned this pull request Feb 17, 2025
Open
5 tasks
@sunng87 sunng87 added this to the v0.13 milestone Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zyy17 zyy17 zyy17 approved these changes

@evenyag evenyag evenyag left review comments

@daviderli614 daviderli614 daviderli614 approved these changes

@waynexia waynexia waynexia approved these changes

Assignees
No one assigned
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Milestone
v0.13
Development

Successfully merging this pull request may close these issues.

ci: update ubuntu-20.04 runners
6 participants
@sunng87 @zyy17 @evenyag @waynexia @daviderli614 @shuiyisong