-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: format all toml files #5529
base: main
Are you sure you want to change the base?
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
You can use |
yes used it too |
I would suggest only lifting common dependencies of multiple modules to workspace level. For our close-sourced downstream projects, we use a trick to manage both open-source code and close-source code with the workspace level cargo.toml. It requires syncing the dependencies section between cargo.tomls, which is a pain. |
I just add #5536 to possibly improve the sync experience. |
Signed-off-by: yihong0618 <[email protected]>
c06a4cf
to
b9ba166
Compare
I hereby agree to the terms of the GreptimeDB CLA.
this patch follow this comment #5523 (comment)
from @shuiyisong all use workplace.true to
DRY
about this patch:
cargo install --git=https://github.com/DevinR528/cargo-sort --branch=main cargo-sort
This patch not fix them all, can check the output below, I am not sure these dependence can be merged like #5523
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
PR Checklist
Please convert it to a draft if some of the following conditions are not met.