Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve a couple of issues around azure blob storage support #3386

Closed
wants to merge 2 commits into from

Conversation

okhaliavka
Copy link

@okhaliavka okhaliavka commented Jan 13, 2025

Fixes #3044
Resolves #3167

Description
There's currently a number of issues with Azure support in kaniko.

#3044 is a bug that makes kaniko completely unable to download build context from Azure Blob Storage, which was probably introduced in 16ed6b2.
When constructing a blob storage client, kaniko is passing an entire context url (e.g. https://accname.blob.core.windows.net/bucket/context.tar.gz) where just an account url (https://accname.blob.core.windows.net/) is expected. As a result, the bucket/context.tar.gz part gets duplicated in the final URL and the blob doesn't get found.

#3167 is rather a usability concern about kaniko requiring users to provide a storage access key as an env var, making it impossible to use better auth methods, such as managed workload identity. Looks like it'd be better to offload authentication to the azidentity library and use the default azure credential chain, letting users decide on the appropriate way to provide storage credentials for kaniko.
To keep things backward-compatible, the existing auth method will be kept and still attempted first. But when an access key is not provided, kaniko will fallback to the default credential chain, instead of immediately failing with an error.

I'm aware that this project is pretty much abandoned, but I still have a tiny glimmer of hope that this contribution will be reviewed 😅 .

Submitter Checklist

Azure blob storage isn't covered by unit/integration tests. Fixing that would require more time that I'm willing to put without any certainty that this PR has a chance to be reviewed and merged.

  • Includes unit tests
  • Adds integration tests if needed.

Reviewer Notes

  • The code flow looks good.
  • Unit tests and or integration tests added.

@okhaliavka okhaliavka changed the title Azure Resolve a couple of issues around azure blob storage support Jan 13, 2025
@okhaliavka okhaliavka closed this Jan 13, 2025
@okhaliavka
Copy link
Author

to be split into separate prs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use Azure Default Credential to avoid using keys Azure Blob Storage Context invalid path
1 participant