Add encoding support for secret values in config package #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced a new field `Encoding` in the `Secret` struct to specify the encoding type of the secret value, currently supporting "base64". - Added a `DecodeContent` method to handle decoding of the secret content based on the specified encoding.
dgulli
requested review from
amitmodak,
NaMNDV,
dargudear-google and
abheda-crest
as code owners
- Update server to handle base64 encoded secrets during mount - Add test cases for base64 and non-encoded secret scenarios - Update example configuration template to demonstrate base64 encoding
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Encodingin theSecretstruct to specify the encoding type of the secret value, currently supporting "base64".DecodeContentmethod to handle decoding of the secret content based on the specified encoding.