Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ops Agent Plugin - Added Config Validation and Conf Generation Logic #1859

Closed
wants to merge 26 commits into from
Closed

Ops Agent Plugin - Added Config Validation and Conf Generation Logic #1859

wants to merge 26 commits into from

Conversation

XuechunHou
Copy link
Contributor

Description

Related issue

How has this been tested?

Checklist:

  • Unit tests
    • Unit tests do not apply.
    • Unit tests have been added/modified and passed for this PR.
  • Integration tests
    • Integration tests do not apply.
    • Integration tests have been added/modified and passed for this PR.
  • Documentation
    • This PR introduces no user visible changes.
    • This PR introduces user visible changes and the corresponding documentation change has been made.
  • Minor version bump
    • This PR introduces no new features.
    • This PR introduces new features, and there is a separate PR to bump the minor version since the last release already.
    • This PR bumps the version.

@XuechunHou
UAP Ops Agent Golang Wrapper.
5a3f914
@XuechunHou
Implement GetStats() and Stop()
00d20dc
@XuechunHou
Redirected wrapper logs into a file.
756130b
@XuechunHou
Trying to make ops agent uap plugin work with the existing Ops Agent
28d0388 
test infra.
@XuechunHou
Fixed error: "Dockerfile was not generated by ./dockerfiles/compile. …
018a4f6 
…Please run `go

run ./dockerfiles`"
@XuechunHou
Fixed "Installed (but unpackaged) file(s) found:/opt/google-cloud-ops…
9c95211 
…-agent/libexec/google_cloud_ops_agent_uap_plugin"
@XuechunHou
The ops agent wrapper no longer logs healthcheck result to `systemtcl
caa6553 
status`. Updated the test to check `health-checks.log` to confirm health
check statuses.
@XuechunHou
Added signal handler in sub go routines.
74e7808
@XuechunHou
Created a child ctx from the parent context for go routines that spanw
0096e64 
off commands that restart.

Also added designated signal handlers for each go routines; the signal
handler responds to SIGTERM and cancels the context on trigger.
@XuechunHou
Took config generation out of goroutine. Failures in config generation
fbc4825 
now causes Start() to return an RPC error. Context will be cancelled on
config generation failures, resulting in GetStatus() returning an
inactive status.
@XuechunHou
Printed the plugin self logs to systemd journal.
094b036
@XuechunHou
Defined a restart limit. If subagents or the diagnostics service fail to
cf7d363 
start up more than 3 times, the plugin will stop restarting the command.
@XuechunHou
Ran go mod tidy.
55b4dc7
@XuechunHou
Added conflicting legacy agent installation detection.
94b4436
@XuechunHou
Fixed conflicting installation verification
8b0370d
@XuechunHou
Added more logging to debug third party test.
299244d
@XuechunHou
If "Loaded: not found" is present in the systemctl status command
7dcb406 
output then the systemd service is also not present. Added the case to
the conflicting installation check.
@XuechunHou
Reverted back to a placeholder plugin.
de4d4d6
@XuechunHou
reverted changes in main_test.go
a89f18c
@XuechunHou
Updated Dockerfile
305ea4b
@XuechunHou
removed unused go module
7eb2f6e
@XuechunHou
renamed ops agent plugin dir
451d21a
@XuechunHou
Added more prints for debugging
5d4beb4
@XuechunHou
dont throw errors on duplicate Start/Stop requests, log instead
15938db
@XuechunHou
removed test code
d7e77b9
@XuechunHou
Added config validation and generation logic
2b0fad2
@XuechunHou XuechunHou closed this Jan 17, 2025
@XuechunHou XuechunHou deleted the ida-ops-agent-uap-plugin branch January 17, 2025 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@XuechunHou