Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A basic Ops Agent Plugin #1858

Merged
merged 26 commits into from
Jan 17, 2025
Merged

A basic Ops Agent Plugin #1858

merged 26 commits into from
Jan 17, 2025

Conversation

XuechunHou
Copy link
Contributor

@XuechunHou XuechunHou commented Jan 15, 2025

Description

  1. Created the directory structure for Ops Agent plugin.
  2. Added a basic Ops Agent plugin that defines placeholder methods for RPC endpoints required by plugin_comm.proto. Actual implementation will come later.
  3. Have to maintain a copy of the plugin_comm.proto in the Ops Agent repo for now, because UAP hasn't exposed it for external dependency yet.

Related issue

b/380277488

How has this been tested?

This PR only includes Initial setup of the Ops Agent plugin with basic structure in place. Tests will be developed alongside implementation in later PRs.

Checklist:

  • Unit tests
    • Unit tests do not apply.
    • Unit tests have been added/modified and passed for this PR.
  • Integration tests
    • Integration tests do not apply.
    • Integration tests have been added/modified and passed for this PR.
  • Documentation
    • This PR introduces no user visible changes.
    • This PR introduces user visible changes and the corresponding documentation change has been made.
  • Minor version bump
    • This PR introduces no new features.
    • This PR introduces new features, and there is a separate PR to bump the minor version since the last release already.
    • This PR bumps the version.

…-agent/libexec/google_cloud_ops_agent_uap_plugin"
status`. Updated the test to check `health-checks.log` to confirm health
check statuses.
off commands that restart.

Also added designated signal handlers for each go routines; the signal
handler responds to SIGTERM and cancels the context on trigger.
now causes Start() to return an RPC error. Context will be cancelled on
config generation failures, resulting in GetStatus() returning an
inactive status.
start up more than 3 times, the plugin will stop restarting the command.
output then the systemd service is also not present. Added the case to
the conflicting installation check.
@XuechunHou XuechunHou force-pushed the ida-ops-agent-uap-plugin branch 4 times, most recently from 1a4cd45 to bd92ade Compare January 15, 2025 21:50
@XuechunHou XuechunHou force-pushed the ida-ops-agent-uap-plugin branch from bd92ade to 7475f4d Compare January 15, 2025 22:16
// ps.GetStatus(ctx, &pb.GetStatusRequest{})
// ps.Stop(ctx, &pb.StopRequest{})
// ps.GetStatus(ctx, &pb.GetStatusRequest{})
// ps.Stop(ctx, &pb.StopRequest{})

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These seem to be test code

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deleted

cmd/ops_agent_uap_plugin/service.go Show resolved Hide resolved
Copy link

@jinghan-ma jinghan-ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Getting this on master should help us with testing the release pipeline for the plugin.

@XuechunHou XuechunHou merged commit 19231ae into master Jan 17, 2025
65 of 69 checks passed
@XuechunHou XuechunHou deleted the ida-ops-agent-uap-plugin branch January 17, 2025 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants