-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A basic Ops Agent Plugin #1858
A basic Ops Agent Plugin #1858
Conversation
…Please run `go run ./dockerfiles`"
…-agent/libexec/google_cloud_ops_agent_uap_plugin"
status`. Updated the test to check `health-checks.log` to confirm health check statuses.
off commands that restart. Also added designated signal handlers for each go routines; the signal handler responds to SIGTERM and cancels the context on trigger.
now causes Start() to return an RPC error. Context will be cancelled on config generation failures, resulting in GetStatus() returning an inactive status.
start up more than 3 times, the plugin will stop restarting the command.
output then the systemd service is also not present. Added the case to the conflicting installation check.
1a4cd45
to
bd92ade
Compare
bd92ade
to
7475f4d
Compare
cmd/ops_agent_uap_plugin/plugin.go
Outdated
// ps.GetStatus(ctx, &pb.GetStatusRequest{}) | ||
// ps.Stop(ctx, &pb.StopRequest{}) | ||
// ps.GetStatus(ctx, &pb.GetStatusRequest{}) | ||
// ps.Stop(ctx, &pb.StopRequest{}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These seem to be test code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
deleted
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Getting this on master should help us with testing the release pipeline for the plugin.
Description
plugin_comm.proto
. Actual implementation will come later.Related issue
b/380277488
How has this been tested?
This PR only includes Initial setup of the Ops Agent plugin with basic structure in place. Tests will be developed alongside implementation in later PRs.
Checklist: