-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for parameter manager regional parameter version render datasource google_parameter_manager_regional_parameter_version_render
#12675
Add support for parameter manager regional parameter version render datasource google_parameter_manager_regional_parameter_version_render
#12675
Conversation
…asource to beta version only
… render datasource
…-render-datasource-support
…-render-datasource-support
…rameter version render datasource
…-render-datasource-support
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @shuyama1, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Note: To use this data source, we must grant the |
@shuyama1 Could you please review this PR? |
@shuyama1 This PR has been waiting for review for 3 weekdays. Please take a look! Use the label |
…-render-datasource-support
@shuyama1 Could you please review this PR? |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 19 Click here to see the affected service packages
Action takenFound 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
🟢 Tests passed during RECORDING mode: 🟢 No issues found for passed tests after REPLAYING rerun. 🟢 All tests passed! |
Sure, taking a look now. Sorry for the delay on reviewing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
Add support for parameter manager regional parameter version render datasource
google_parameter_manager_regional_parameter_version_render
.More info about parameter manager: https://cloud.google.com/secret-manager/parameter-manager/docs/overview
Note: This PR is dependent upon the parameter manager regional parameter version resource and datasource which will be added as a part of the PRs #12642 and #12650 respectively.
Important Note:
If the parameter version is disabled, the API will return a 500 Internal Server Error and this datasource will retry until it hits timeout.
To ensure the proper functioning of this datasource, the principal associated with the parameter must have the Secret Manager Secret Accessor role.
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.