Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for parameter manager regional parameter version render datasource google_parameter_manager_regional_parameter_version_render #12675

Conversation

abheda-crest
Copy link
Contributor

@abheda-crest abheda-crest commented Dec 31, 2024

Add support for parameter manager regional parameter version render datasource google_parameter_manager_regional_parameter_version_render.

More info about parameter manager: https://cloud.google.com/secret-manager/parameter-manager/docs/overview

Note: This PR is dependent upon the parameter manager regional parameter version resource and datasource which will be added as a part of the PRs #12642 and #12650 respectively.

Important Note:

  • If the parameter version is disabled, the API will return a 500 Internal Server Error and this datasource will retry until it hits timeout.

  • To ensure the proper functioning of this datasource, the principal associated with the parameter must have the Secret Manager Secret Accessor role.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

`google_parameter_manager_regional_parameter_version_render` (beta)

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Dec 31, 2024
@abheda-crest abheda-crest marked this pull request as ready for review January 30, 2025 12:28
@github-actions github-actions bot requested a review from shuyama1 January 30, 2025 12:28
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@shuyama1, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@abheda-crest
Copy link
Contributor Author

I've attached screenshot for the local test run for the test cases for google_parameter_manager_regional_parameter_version_render datasource:

image

@abheda-crest
Copy link
Contributor Author

Note: To use this data source, we must grant the Secret Manager Secret Accessor role to the principal of the parameter. Please note that it can take up to 7 minutes for the role to take effect. Hence, we might need to wait approximately 7 minutes after granting Secret Manager Secret Accessor role to the principal of the parameter. For more information see the access change propagation documentation.

@abheda-crest
Copy link
Contributor Author

@shuyama1 Could you please review this PR?

Copy link

github-actions bot commented Feb 4, 2025

@shuyama1 This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

@abheda-crest
Copy link
Contributor Author

@shuyama1 Could you please review this PR?

@modular-magician modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Feb 4, 2025
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 58 insertions(+))
google-beta provider: Diff ( 4 files changed, 853 insertions(+), 231 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 19
Passed tests: 16
Skipped tests: 0
Affected tests: 3

Click here to see the affected service packages
  • parametermanagerregional

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDataSourceParameterManagerRegionalRegionalParameterVersionRender_basicWithResourceReference
  • TestAccDataSourceParameterManagerRegionalRegionalParameterVersionRender_withJsonData
  • TestAccDataSourceParameterManagerRegionalRegionalParameterVersionRender_withYamlData

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccDataSourceParameterManagerRegionalRegionalParameterVersionRender_basicWithResourceReference [Debug log]
TestAccDataSourceParameterManagerRegionalRegionalParameterVersionRender_withJsonData [Debug log]
TestAccDataSourceParameterManagerRegionalRegionalParameterVersionRender_withYamlData [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@shuyama1
Copy link
Member

shuyama1 commented Feb 5, 2025

@shuyama1 Could you please review this PR?

Sure, taking a look now. Sorry for the delay on reviewing

Copy link
Member

@shuyama1 shuyama1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@shuyama1 shuyama1 added this pull request to the merge queue Feb 5, 2025
Merged via the queue into GoogleCloudPlatform:main with commit 737a059 Feb 5, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants