Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(pull request template): mark shared-configuration step as required #10016

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cabljac
Copy link

@cabljac cabljac commented Feb 6, 2025

This PR marks adding the shared config to the pom.xml as a required step in the pull request template. As I understand, it affects later required steps like linting?

This PR marks adding the shared config to the pom.xml as a required step in the pull request template,
as it affects later required steps.
@cabljac cabljac requested review from yoshi-approver and a team as code owners February 6, 2025 12:24
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Feb 6, 2025
@minherz minherz marked this pull request as draft February 16, 2025 02:16
@minherz
Copy link
Contributor

minherz commented Feb 16, 2025

This PR makes unnecessary modification to the PR template. Please, avoid modifying templates and other settings for this repository.
I have temporary converted this PR to draft. Please provide an issue that you are trying to solve.The description should justify the change to the requirements as well as to describe the plan of updating all POM files in all code samples to align with the requirement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants