Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version updates: App Engine: Qwik Start - Java #10010

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

manishchaudhari-ssk
Copy link

  • Updated the Java version in app.yaml in app-engine-java21 directory
  • Buganizer: http://b/393352626

Copy link

snippet-bot bot commented Feb 3, 2025

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Feb 3, 2025
Copy link
Contributor

@code-review-assist code-review-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi team,

I'm currently reviewing this pull request and will provide my feedback shortly. In the meantime, here's a summary of the changes for you and other reviewers to get up to speed quickly:

This pull request updates the Java version in the App Engine Qwik Start sample to Java 21. The changes are focused on the appengine-java21/helloworld/http-server directory.

Intent:

The primary goal is to modernize the sample application by using the latest Java version, improving compatibility and potentially leveraging new features.

Changes:

  • The app.yaml file was updated to specify runtime: java21. (Line 16 of appengine-java21/helloworld/http-server/src/main/appengine/app.yaml)
  • A new README.md file was added to provide instructions for deploying the updated application. (File: appengine-java21/helloworld/http-server/README.md)
  • The pom.xml file was updated to reflect the Java 21 runtime. (File: appengine-java21/helloworld/http-server/pom.xml)
  • The main application file (Main.java) remains largely unchanged, demonstrating a simple HTTP server. (File: appengine-java21/helloworld/http-server/src/main/java/com/example/appengine/Main.java)

Activity:

The pull request references Buganizer issue http://b/393352626, suggesting this is part of a larger effort to update App Engine samples.

I'll provide a more detailed review shortly. Thanks!


And now, a little haiku to brighten your day:

Java twenty-one,
Code compiles, a clean deploy,
Happy coding now!

Copy link
Contributor

@code-review-assist code-review-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request updates the Java version to Java 21 in the App Engine sample application. The changes include updating app.yaml, adding a pom.xml for Maven build management, and creating a README.md file with instructions. The implementation looks good overall, and the added documentation is helpful. Here are a few minor suggestions:

Summary of Google Java Style Guide elements referenced:

  • Comments: Documented using Javadoc style.
  • Naming: Used descriptive names for classes and variables.

@minherz minherz removed their assignment Feb 3, 2025
@iennae iennae added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Feb 11, 2025
@kokoro-team kokoro-team removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants