Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Node Topology CRD definition. #22

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

sawsa307
Copy link
Contributor

No description provided.

Copy link
Contributor

Hi @sawsa307. Thanks for your PR.

I'm waiting for a GoogleCloudPlatform member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

apis/topology/v1/types.go Outdated Show resolved Hide resolved
@sawsa307 sawsa307 force-pushed the topology-crd branch 2 times, most recently from 19156de to 219c15b Compare August 22, 2024 20:11
@sawsa307 sawsa307 changed the title Add Topology CRD definition. Add Node Topology CRD definition. Aug 26, 2024
apis/nodetopology/v1/types.go Outdated Show resolved Hide resolved
apis/nodetopology/v1/types.go Show resolved Hide resolved
apis/nodetopology/v1/types.go Show resolved Hide resolved
apis/nodetopology/v1/types.go Outdated Show resolved Hide resolved
apis/nodetopology/v1/types.go Outdated Show resolved Hide resolved
@sawsa307 sawsa307 force-pushed the topology-crd branch 4 times, most recently from 7147539 to b6c4896 Compare September 3, 2024 20:20
@sawsa307 sawsa307 requested a review from bowei September 4, 2024 18:15
* NodeTopology will be a cluster-wide resource, describing the subnets
  used by this cluster and its current node zones.
@bowei
Copy link
Member

bowei commented Sep 9, 2024

/lgtm
/approve

Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bowei, sawsa307

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants