Update Metabase to v0.41.0 #53
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* let users disable attachments with questions checked * use more declarative assertions in unit tests * use aria-label over testid * translate aria label
…n moving between sidebar views (metabase#17791) * don't set pulse on SharingSidebar mount * remove some old, unused code
…etabase#17761) Merging on behalf of Nemanja * Attempt to fix metabase#17751 * Revert limiting max-width on a parent div * Inherit min-width from a parent div * Unskip repro
* Pass along date formatting * extract and rename some things * Number formatting * Update tests * Improve test validation of svg labels * Clean up tests * Move static-viz interface file to custom file
…y access to a collection (metabase#17722)
* don't show exact seconds for a formatted relative time * add a couple of getRelativeTimeAbbreviated tests
There's more to come WRT the audits, but anton and I agreed to merge something faster and work on that stuff after
This was a miserable grind in the old BQ syntax but a happy fun time in the new BQ syntax, basically just turning it on and squashing a bunch of test bugs. One test bug to note especially is that the underscore-transformed set of bird scarcity data for the bird scarcity tests is actually necessary, because BQ will hit you with a complaint about underscores even if you successfully and correctly quote the table names.
* Basic skeleton of front-end dependencies analyzer * Parse enterprise/frontend * Handle good ol' require * For sanity, bail out immediately when encountering a parse errr * Split into commands (currently returning JSON) * Filter dependents from stdin * Track down all dependents, including the indirect/transitive ones * Fix filtering not including the enterprise * Map a directory to its index.js, if it exists * Refactor common functions * Matrix and count dependents
* raw tags * index to start * update toc link * reference link
Add parameter handling for BigDecimal that checks whether the value is in range for BIGNUMERIC or BIGDECIMAL and sets accordingly Updating parameter test to hit both these cases Modifying test code/macros to support a with-table semantic for testing the decimal types via a temp table Writing new test to confirm that all numeric types are synced correctly and can be queried for
* restyle the Verify button * remove unused components * make the verify button blue Co-authored-by: Maz Ameli <[email protected]>
…et" (metabase#18263) * Fix virtual fields are missing in ParameterValueWidget * fix fk filter parameters Co-authored-by: Alexander Lesnenko <[email protected]>
Co-authored-by: Maz Ameli <[email protected]>
…8237) * Fix Dashboard Subscription email validation (second pass) * Always validate Pulse channels in test endpoint
…g in order clause (metabase#18221) Remove the `driver/format-custom-field-name` implementation for :snowflake, which was causing the problem and appears to be no longer needed anyway Add test for this scenario to `metabase.query-processor-test.expression-aggregations-test`
…tabase#18274) Co-authored-by: Justin McCarthy <[email protected]> Co-authored-by: Pawit Pornkitprasan <[email protected]>
* Add `setupSMTP` helper function * Remove deprecated `setupDummySMTP` helper * Re-use `setupSMTP` helper in tests * Always clear Webmail's inbox after setting up the SMTP Co-authored-by: Nemanja Glumac <[email protected]>
metabase#18270) (metabase#18296) Change implementation of docsUrl to handle RC suffixes for EE versions Change the regex used to test the tag to detect any OSS or EE version, including (possibly) an arbitrary suffix after the major and minor parts, and normalize to the major OSS equivalent version instead. If the suffix, OTOH, is `-SNAPSHOT` (ignoring case), then the doc tag will be `latest`, on the theory that this is as local development build. v0.41.0 => v0.41 v1.41.1 => v0.41 v1.41.2-RC1 => v0.41 v1.42.0-SNAPSHOT => latest Adding unit tests for all cases Update behavior so that -SNAPSHOT suffix points to "latest" Co-authored-by: Jeff Evans <[email protected]>
Co-authored-by: Cam Saul <[email protected]>
Previous PRs for error cards page were laser focused on getting everything to work, as opposed to actually conforming to spec. This one gets it closer to spec, although product wants reloading animations which are not there yet. To wit, - Indicates to end user what the current running state is. Given the many orders of magnitude in DB query run times I think something robust and non-ephemeral is necessary here (looking at some sort of expanded QE model) but Maz suggested expedient method and I took it - No more left nav on the table page - Page heading for table page - Independent scroll-x behavior on the table - Styling for the error section on the table page - Select-all component. Note that the interaction behavior with pagination is fiddly. (but less fiddly now that it's all based on card id's instead of row numbers) - Coalescing default behavior for Our Analytics collection (default collection) and null number of dashboards Rename error name to error content search
* Static viz: respect custom X and Y axis labels * Static viz: allow rendering non-timeseries line charts * Test fixes 🔧
r351574nc3
force-pushed
the
feat/circleci-image-build
branch
from
0e9bb5a to
122f660
Compare
r351574nc3
force-pushed
the
feat/circleci-image-build
branch
from
122f660 to
002c25d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
v0.41.0changes from upstream repository