Compile with warning as error #74

fghoussen · 2023-07-25T08:39:21Z

Compile with warning as error.

Note: gave up on Qt deprecated declarations for a start...

…tion of ‘q’ shadows a member of ‘qglviewer::Quaternion’ [-Werror=shadow] 170 | Quaternion &operator*=(const Quaternion &q) { | ~~~~~~~~~~~~~~~~~~^ /tmp/libQGLViewer/build/QGLViewer_autogen/QGLViewer/quaternion.h:309:9: note: shadowed declaration is here 309 | qreal q[4]; | ^

…declaration of ‘d’ shadows a member of ‘BSPNode’ [-Werror=shadow] 542 | void BSPNode::initEquation(const Polygone *P,double & a, double & b, double & c, double & d) | ~~~~~~~~~^ /tmp/libQGLViewer/QGLViewer/VRender/BSPSortMethod.cpp:93:30: note: shadowed declaration is here 93 | double a,b,c,d; | ^

…declaration of ‘c’ shadows a member of ‘BSPNode’ [-Werror=shadow] 542 | void BSPNode::initEquation(const Polygone *P,double & a, double & b, double & c, double & dd) | ~~~~~~~~~^ /tmp/libQGLViewer/QGLViewer/VRender/BSPSortMethod.cpp:93:28: note: shadowed declaration is here 93 | double a,b,c,d; | ^

…declaration of ‘b’ shadows a member of ‘BSPNode’ [-Werror=shadow] 542 | void BSPNode::initEquation(const Polygone *P,double & a, double & b, double & c, double & dd) | ~~~~~~~~~^ /tmp/libQGLViewer/QGLViewer/VRender/BSPSortMethod.cpp:93:26: note: shadowed declaration is here 93 | double a,b,c,d; | ^

…declaration of ‘a’ shadows a member of ‘BSPNode’ [-Werror=shadow] 542 | void BSPNode::initEquation(const Polygone *P,double & a, double & bb, double & cc, double & dd) | ~~~~~~~~~^ /tmp/libQGLViewer/QGLViewer/VRender/BSPSortMethod.cpp:93:24: note: shadowed declaration is here 93 | double a,b,c,d; | ^

… vrender::operator*(const NVector3&, const Vector3&)’ has not been declared within ‘vrender’ [-Werror] 41 | double vrender::operator*(const NVector3 &u,const Vector3 &v) | ^~~~~~~ In file included from /tmp/libQGLViewer/QGLViewer/VRender/NVector3.cpp:1: /tmp/libQGLViewer/QGLViewer/VRender/NVector3.h:45:19: note: only here as a ‘friend’ 45 | friend double operator*(const NVector3 &u,const Vector3 &v); | ^~~~~~~~

… vrender::operator*(const Vector3&, const NVector3&)’ has not been declared within ‘vrender’ [-Werror] 46 | double vrender::operator*(const Vector3 &u,const NVector3 &v) | ^~~~~~~ In file included from /tmp/libQGLViewer/QGLViewer/VRender/NVector3.cpp:1: /tmp/libQGLViewer/QGLViewer/VRender/NVector3.h:46:19: note: only here as a ‘friend’ 46 | friend double operator*(const Vector3 &u,const NVector3 &v); | ^~~~~~~~

…::ostream& vrender::operator<<(std::ostream&, const Feedback3DColor&)’ has not been declared within ‘vrender’ [-Werror] 121 | std::ostream& vrender::operator<<(std::ostream& o,const Feedback3DColor& f) | ^~~~~~~ In file included from /tmp/libQGLViewer/QGLViewer/VRender/Primitive.cpp:3: /tmp/libQGLViewer/QGLViewer/VRender/Primitive.h:61:38: note: only here as a ‘friend’ 61 | friend std::ostream& operator<<(std::ostream&,const Feedback3DColor&) ; | ^~~~~~~~

…::Vector2 vrender::operator-(const Vector2&)’ has not been declared within ‘vrender’ [-Werror] 50 | Vector2 vrender::operator- (const Vector2& u) | ^~~~~~~ In file included from /tmp/libQGLViewer/QGLViewer/VRender/Vector2.cpp:1: /tmp/libQGLViewer/QGLViewer/VRender/Vector2.h:73:40: note: only here as a ‘friend’ 73 | friend Vector2 operator- (const Vector2&); | ^~~~~~~~

…::Vector3 vrender::operator*(double, const Vector3&)’ has not been declared within ‘vrender’ [-Werror] 81 | Vector3 vrender::operator* (double r,const Vector3& u) | ^~~~~~~ In file included from /tmp/libQGLViewer/QGLViewer/VRender/Vector3.cpp:2: /tmp/libQGLViewer/QGLViewer/VRender/Vector3.h:114:40: note: only here as a ‘friend’ 114 | friend Vector3 operator* (double,const Vector3&); | ^~~~~~~~

…ostream& vrender::operator<<(std::ostream&, const Vector3&)’ has not been declared within ‘vrender’ [-Werror] 111 | std::ostream& vrender::operator<< (std::ostream& out,const Vector3& u) | ^~~~~~~ /tmp/libQGLViewer/QGLViewer/VRender/Vector3.h:127:46: note: only here as a ‘friend’ 127 | friend std::ostream& operator<< (std::ostream&,const Vector3&); | ^~~~~~~~

…‘proj’ shadows a previous local [-Werror=shadow] 1038 | qreal proj = fabs(directions[0][i] * dir); | ^~~~ /tmp/libQGLViewer/QGLViewer/frame.cpp:1009:9: note: shadowed declaration is here 1009 | qreal proj; | ^~~~

…‘axis’ shadows a previous local [-Werror=shadow] 1046 | const Vec axis = cross(directions[0][index[0]], dir); | ^~~~ /tmp/libQGLViewer/QGLViewer/frame.cpp:1025:15: note: shadowed declaration is here 1025 | const Vec axis = cross(directions[0][index[0]], directions[1][index[1]]); | ^~~~

…‘angle’ shadows a previous local [-Werror=shadow] 1047 | qreal angle = asin(axis.norm()); | ^~~~~ /tmp/libQGLViewer/QGLViewer/frame.cpp:1026:11: note: shadowed declaration is here 1026 | qreal angle = asin(axis.norm()); | ^~~~~

…eclaration of ‘v1’ shadows a member of ‘qglviewer::KeyFrameInterpolator’ [-Werror=shadow] 340 | Vec v1 = 3.0 * diff - 2.0 * kf_[1]->tgP() - kf_[2]->tgP(); | ^~ In file included from /tmp/libQGLViewer/QGLViewer/camera.h:5, from /tmp/libQGLViewer/QGLViewer/qglviewer.h:4, from /tmp/libQGLViewer/QGLViewer/keyFrameInterpolator.cpp:2: /tmp/libQGLViewer/QGLViewer/keyFrameInterpolator.h:354:7: note: shadowed declaration is here 354 | Vec v1, v2; | ^~

…eclaration of ‘v2’ shadows a member of ‘qglviewer::KeyFrameInterpolator’ [-Werror=shadow] 341 | Vec v2 = -2.0 * diff + kf_[1]->tgP() + kf_[2]->tgP(); | ^~ In file included from /tmp/libQGLViewer/QGLViewer/camera.h:5, from /tmp/libQGLViewer/QGLViewer/qglviewer.h:4, from /tmp/libQGLViewer/QGLViewer/keyFrameInterpolator.cpp:2: /tmp/libQGLViewer/QGLViewer/keyFrameInterpolator.h:354:11: note: shadowed declaration is here 354 | Vec v1, v2; | ^~

… of ‘text’ shadows a previous local [-Werror=shadow] 1897 | QString text = mouseActionString(itmb.value().action); | ^~~~ /tmp/libQGLViewer/QGLViewer/qglviewer.cpp:1846:11: note: shadowed declaration is here 1846 | QString text( | ^~~~

… of ‘text’ shadows a previous local [-Werror=shadow] 1921 | QString text = mouseActionString(itw.value().action); | ^~~~ /tmp/libQGLViewer/QGLViewer/qglviewer.cpp:1846:11: note: shadowed declaration is here 1846 | QString text( | ^~~~

… of ‘q’ shadows a member of ‘qglviewer::Quaternion’ [-Werror=shadow] 227 | Quaternion q(element); | ^ In file included from /tmp/libQGLViewer/QGLViewer/quaternion.cpp:1: /tmp/libQGLViewer/QGLViewer/quaternion.h:309:9: note: shadowed declaration is here 309 | qreal q[4]; | ^

fghoussen · 2023-07-25T17:53:01Z

#75 (comment): seems there are cross dependencies between NVector3 and Vector3: they both need each other.

@GillesDebunne: cross dependency should be broken, not sure what is better as I don't know how code was designed. My understanding is that NVector3 is just for having normalized vector so removing NVector3 but adding a bool normalized member in Vector3 could break the cross dependency (?) and allow easy define/implementation/link with all kind of operators (which will then need to be defined only once)

/usr/bin/ld: libQGLViewer.so: undefined reference to `vrender::operator*(vrender::Vector3 const&, vrender::NVector3 const&)'
/usr/bin/ld: libQGLViewer.so: undefined reference to `vrender::operator<<(std::ostream&, vrender::Vector3 const&)'
/usr/bin/ld: libQGLViewer.so: undefined reference to `vrender::operator-(vrender::Vector2 const&)'
/usr/bin/ld: libQGLViewer.so: undefined reference to `vrender::operator*(double, vrender::Vector3 const&)'
/usr/bin/ld: libQGLViewer.so: undefined reference to `vrender::operator*(vrender::NVector3 const&, vrender::Vector3 const&)'
collect2: error: ld returned 1 exit status

… const&)

…be explicitly initialized in the copy constructor [-Werror=extra] 21 | NVector3::NVector3(const NVector3& u)

… ‘CameraViewer’ [-Werror=shadow] 16 | const float c = cos(angle); | ^

fghoussen · 2023-07-27T08:41:41Z

The last warnings are Qt deprecation which fix may depend on version Qt5/6...
Would be good to get rid of -Wno-error=deprecated-declarations.

fghoussen added 21 commits July 25, 2023 10:24

Compile with warning as error.

0a0690a

Skip Qt deprecated declarations for now...

6060d1f

fghoussen mentioned this pull request Jul 25, 2023

Compile with warning as error fails!... #75

Open

fghoussen added 7 commits July 27, 2023 09:52

Kill cross dependency between Vector3 and NVector3.

a699062

Fix Vector2 link error: undefined vrender::operator-(vrender::Vector2…

b601b9e

… const&)

Vector2: all operators must be inlined in header.

328b5c2

NVector3: all operators must be inlined in header.

4dc9899

Reorder operators + comment: they all must be implemented in the header.

58bce2b

NVector3.cpp:21:1: error: base class ‘class vrender::Vector3’ should …

e6746e0

…be explicitly initialized in the copy constructor [-Werror=extra] 21 | NVector3::NVector3(const NVector3& u)

cameraViewer.cpp:16:17: error: declaration of ‘c’ shadows a member of…

8c7e133

… ‘CameraViewer’ [-Werror=shadow] 16 | const float c = cos(angle); | ^

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Compile with warning as error #74

Compile with warning as error #74

fghoussen commented Jul 25, 2023

fghoussen commented Jul 25, 2023 •

edited

Loading

fghoussen commented Jul 27, 2023

Compile with warning as error #74

Are you sure you want to change the base?

Compile with warning as error #74

Conversation

fghoussen commented Jul 25, 2023

fghoussen commented Jul 25, 2023 • edited Loading

fghoussen commented Jul 27, 2023

fghoussen commented Jul 25, 2023 •

edited

Loading