Remove length limit on oplog fields #369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In particular, Mythic agents can generate very long IP address entries on agents that have multiple IPv6 NICs that would overflow the 255 character limit.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #369 +/- ##
==========================================
- Coverage 92.27% 92.26% -0.02%
==========================================
Files 255 256 +1
Lines 15996 16006 +10
==========================================
+ Hits 14761 14768 +7
- Misses 1235 1238 +3 ☔ View full report in Codecov by Sentry. |
chrismaddalena
added a commit
that referenced
this pull request
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Internal issue
Description of the Change
Change OpLog
CharFields to (a thin wrapper around)TextFieldsthat support much larger storage.Alternate Designs
Possible Drawbacks
Verification Process
Made an oplog entry with very long text for the source IP address
Release Notes