-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fuels dev
hangs after compilation errors
#3646
Open
nedsalk
wants to merge
6
commits into
master
Choose a base branch
from
ns/fix/fuels-dev-hang
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+55
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nedsalk
requested review from
digorithm,
arboleya,
Torres-ssf,
danielbate and
petertonysmith94
as code owners
January 30, 2025 13:57
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
nedsalk
force-pushed
the
ns/fix/fuels-dev-hang
branch
from
January 30, 2025 13:59
8fd1265
to
6a2b369
Compare
4 tasks
I had to do a force push to reset the commit history because it had @Dhaiwat10's commits in it, which triggered the |
arboleya
reviewed
Jan 30, 2025
arboleya
approved these changes
Jan 30, 2025
Coverage Report:
Changed Files:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fuels dev
hangs on generating types #1886Release notes
In this release, we:
fuels dev
would hang after a Sway compilation errorSummary
This PR fixes the issue where
fuels dev
would hang after a Sway compilation error. Thebuild
process was failing and the failure was caught, but thereject
callback that is called on failure was being called with an error code1
, which can't be rethrown later once thereject
's error is caught in atry/catch
- it has to be anError
object. After changing it to anError(forc exited with exit code ${code})
, I realized that the error handlers present in thosetry/catch
es weren't re-throwing the caught error. After adding a re-throw in them, I found out that the error was further being swallowed in thebin.ts
file. The bug was fixed upon changing that.Checklist