[BUGFIX] Add UnionTypes for method arguments #676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you very much. I will have a look at it. |
PKuhlmay
force-pushed
the
master
branch
2 times, most recently
from
135b509 to
62c8064
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the extension builder fails to save an extension, if a methods argument type is a union type.
After merging this patch, Union Types are allowed. For simple types like null, int, float, bool, string, array, callable, object and mixed no backslash will be prefixed to the type.
This needs to be tested, if I miss any simple types in the list. Otherwise a backslash will be prefixed unnecessary and the PHP-Code will likely fail.