680 - storing authors inside composer.json

FriendsOfTYPO3 · Dec 28, 2023 · 518ca73 · 518ca73
1 parent 8d151ba
commit 518ca73
Showing 1 changed file with 12 additions and 11 deletions.
diff --git a/Classes/Domain/Model/Extension.php b/Classes/Domain/Model/Extension.php
@@ -637,14 +637,24 @@ public function setSourceLanguage(string $sourceLanguage): void
     public function getComposerInfo(): array
     {
         // TODO: consider moving this into the CodeTemplates
-        // TODO: authors are not stored here
+        $authors = [];
+        foreach ($this->persons as $person) {
+            $author = [
+                'name' => $person->getName()
+            ];
+            if ($person->getRole() !== '') {
+                $author['role'] = $person->getRole();
+            }
+            $authors[] = $author;
+        }
+
         $extensionKey = $this->extensionKey;
         $composerExtensionKey = strtolower(str_replace('_', '-', $extensionKey));
         $info = [
             'name' => strtolower(str_replace('_', '', GeneralUtility::camelCaseToLowerCaseUnderscored($this->vendorName))) . '/' . $composerExtensionKey,
             'type' => 'typo3-cms-extension',
             'description' => $this->description,
-            'authors' => [],
+            'authors' => $authors,
             'license' => 'GPL-2.0-or-later',
             'require' => [
                 'typo3/cms-core' => '^12.4'
@@ -681,15 +691,6 @@ public function getComposerInfo(): array
                 ]
             ]
         ];
-        foreach ($this->persons as $person) {
-            $author = [
-                'name' => $person->getName()
-            ];
-            if ($person->getRole() !== '') {
-                $author['role'] = $person->getRole();
-            }
-            $info['authors'][] = $author;
-        }
         return $info;
     }
 }