Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix comment in config defaults header file #189

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

samryanuofl
Copy link
Contributor

Clean up comment in core_http_config_defaults.h

Description

The comment for the HTTP_RECV_RETRY_TIMEOUT_MS config item references HTTPClient_Send when I think it actually applies to HTTPClient_ReceiveAndParseHttpResponse (based on the name and because that is where this value is used in the source). Updated the comment but feel free to close if I'm mistaken.

Test Steps

Checklist:

Have a linker error that I need to debug when trying to build the tests so haven't run those, comment change only though

  • I have tested my changes. No regression in existing tests.
  • I have modified and/or added unit-tests to cover the code changes in this Pull Request.

Related Issue

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@felicityzhao9
Copy link
Member

Thanks for your contribution! We'll merge your change shortly.

@felicityzhao9 felicityzhao9 merged commit 822b750 into FreeRTOS:main Jan 16, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants