Return os name "win64" on Win x64 #183
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbernhagen
force-pushed
the
os-name-win64-for-win-x64
branch
from
3c27639 to
7479687
Compare
|
Let's hold off on this for now. There's a high probability it will break something. I'd like to get the alpha out first. |
kbernhagen
force-pushed
the
os-name-win64-for-win-x64
branch
from
7479687 to
b1732b0
Compare
jcoffland
force-pushed
the
master
branch
3 times, most recently
from
e88d016 to
4a2ed73
Compare
jcoffland
force-pushed
the
master
branch
4 times, most recently
from
b719a0c to
e23825b
Compare
jcoffland
force-pushed
the
master
branch
8 times, most recently
from
4a29589 to
99ae953
Compare
jhitze
reviewed
Nov 2, 2024
| const char *WinOSImpl::getName() const { | ||
| #ifdef _WIN64 | ||
| return "win64"; | ||
| #else |
There was a problem hiding this comment.
win32 isn't the only other option; this ignores 16 and ARM. It'd probably be simpler to just return win64 instead, since it's only compiled for 64bit computers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is assuming all servers can handle both "win32" and "win64".