cmd/age: also fallback to stdin and stdout, if /dev/tty exists, but cannot be opened #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FiloSottile
reviewed
May 3, 2022
FiloSottile
reviewed
May 4, 2022
… be opened - remove unneeded stat syscall
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mention here [0], I had a problem when /dev/tty exists, but age failed to open it. Now age falls back to /dev/tty, which is the same behavior as if /dev/tty does not exist.
If there are additional changes needed, I am happy to implement them.
PS: Thank you very much for this great tool!
[0] #279 (comment)