Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.4 Support #904

Merged
merged 6 commits into from
Nov 7, 2024
Merged

PHP 8.4 Support #904

merged 6 commits into from
Nov 7, 2024

Conversation

Jubeki
Copy link

@Jubeki Jubeki commented Oct 3, 2024

What is the reason for this PR?

  • A new feature
  • Fixed an issue

Author's checklist

Summary of changes

  • Adds PHP 8.4 to Test Matrix
  • Add explicit nullable declarations to remove PHP 8.4 deprecations.
  • Add nullable_type_declaration_for_default_null_value to Coding Standards

Review checklist

  • All checks have passed
  • Changes are added to the CHANGELOG.md
  • Changes are approved by maintainer

@Jubeki Jubeki marked this pull request as ready for review October 3, 2024 10:00
@Jubeki Jubeki changed the title [1.23] PHP 8.4 Support PHP 8.4 Support Oct 3, 2024
@pimjansen
Copy link

Thanks! Will review later. Initially it all looks fine

@Jubeki
Copy link
Author

Jubeki commented Oct 3, 2024

I think the Static analysis / Psalm failure is unrelated to this PR.

@pimjansen
Copy link

I think the Static analysis / Psalm failure is unrelated to this PR.

Well im not even getting them locally indeed.

@pimjansen
Copy link

@localheinz you got an idea what this could be? Also the error makes no direct sense to me at all

@pimjansen
Copy link

Can we recreate the baseline here?

@Jubeki
Copy link
Author

Jubeki commented Nov 4, 2024

@pimjansen I have updated the baseline.

@Jubeki
Copy link
Author

Jubeki commented Nov 4, 2024

Seems like there is still a problem with the baseline.

I updated it using the following command:

vendor/bin/psalm --no-progress --update-baseline

(Never used psalm before)

@pimjansen
Copy link

pimjansen commented Nov 4, 2024

Me neither so thats why i pinged @localheinz haha. Since i want this PR to be done so we can continue in other libs as well

@Jubeki
Copy link
Author

Jubeki commented Nov 7, 2024

@pimjansen Okay I have found the problem regarding the baseline.

The option --update-baseline will only removed solved problems from the baseline, it will not add new ones. For that you need to run --set-baseline=psalm.baseline.xml.

I have now added a regenrated psalm baseline, which should make this PR mergeable.

@pimjansen pimjansen requested review from pimjansen and removed request for pimjansen November 7, 2024 15:09
@pimjansen
Copy link

LGTM, cant somehow not merge this via mobile will review tomorrow and push for a 1.24 release

@pimjansen pimjansen merged commit a136842 into FakerPHP:1.23 Nov 7, 2024
13 checks passed
@pimjansen
Copy link

Good work!

@Jubeki
Copy link
Author

Jubeki commented Nov 7, 2024

Thanks!

@Jubeki Jubeki deleted the php84 branch November 7, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants