-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHP 8.4 Support #904
PHP 8.4 Support #904
Conversation
Thanks! Will review later. Initially it all looks fine |
I think the Static analysis / Psalm failure is unrelated to this PR. |
Well im not even getting them locally indeed. |
@localheinz you got an idea what this could be? Also the error makes no direct sense to me at all |
Can we recreate the baseline here? |
@pimjansen I have updated the baseline. |
Seems like there is still a problem with the baseline. I updated it using the following command:
(Never used psalm before) |
Me neither so thats why i pinged @localheinz haha. Since i want this PR to be done so we can continue in other libs as well |
@pimjansen Okay I have found the problem regarding the baseline. The option I have now added a regenrated psalm baseline, which should make this PR mergeable. |
LGTM, cant somehow not merge this via mobile will review tomorrow and push for a 1.24 release |
Good work! |
Thanks! |
What is the reason for this PR?
Author's checklist
Summary of changes
nullable_type_declaration_for_default_null_value
to Coding StandardsReview checklist
CHANGELOG.md