Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI not catching failures reliably #318

Open
IAmMarcelJung opened this issue Feb 6, 2025 · 2 comments
Open

CI not catching failures reliably #318

IAmMarcelJung opened this issue Feb 6, 2025 · 2 comments
Labels
bug Something isn't working testing Integration and testing related

Comments

@IAmMarcelJung
Copy link
Collaborator

As mentioned in #316, the current CI does not check for all failures, e.g. if a command returns instead of throwing an error so that the FABulous shell does not terminate.

Since we should not rely on the code throwing errors for the current test setup (since this can cause the checks to falsely pass) we should implement another way to check if the test run was actually successful. In the future we should also completely update our test setup, but for now maybe there is a simple soultion for this like checking a log or checking for the existence of file.

@IAmMarcelJung IAmMarcelJung added bug Something isn't working testing Integration and testing related labels Feb 6, 2025
@IAmMarcelJung
Copy link
Collaborator Author

This could be a duplicate of #147?

@EverythingElseWasAlreadyTaken
Copy link
Collaborator

For a quick fix, I'll add a workflow, which also runs the simulation standalone, without the usage of the CLI.

In general, we should maybe divide down the CLI and the script interfaces, all functions called via scripts should throw errors, the CLI functions should rather be wrappers around them, that should be able to catch these exceptions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working testing Integration and testing related
Projects
None yet
Development

No branches or pull requests

2 participants