Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

making auth page that contain complaint and suggestion with user who … #29

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

InassTubail
Copy link
Contributor

@InassTubail InassTubail commented May 28, 2018

Related

related to #15

Summary

1- src/views/suggestion & complaints hbs
2-selection suggestion & complaints by user name "sql"
3- src/controllers/suggestion_complaint.js
4-make additional authorization for cf and student in src/controller/check-outh.js
5- abstract some queries from src/controller/passport-setup.js

Copy link
Contributor

@walaamedhat walaamedhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job ,


exports.isCF = (req, res, next) => {
if (req.user.role === 'cf') {
console.log('CF Authorized');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove console from your file befor you pushed it

});
}
});
}
});
// request(options, (error, response, body) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove all comments please

@walaamedhat
Copy link
Contributor

Close the issues that you're finished it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants