refactor: build list item bindings

Ephigenia · Jan 5, 2017 · 1e139bb · 1e139bb
1 parent f0a849e
commit 1e139bb
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 15 deletions.
diff --git a/source/scripts/BuildList.js b/source/scripts/BuildList.js
@@ -9,7 +9,6 @@
     },
     templateUrl: 'scripts/BuildList.html',
     controller: function() {
-
     }
   });
 })();
diff --git a/source/scripts/BuildListItem.js b/source/scripts/BuildListItem.js
@@ -15,15 +15,15 @@
       controller: function($filter, $element) {
         var ctrl = this;
 
-        // @TODO when failed colorize the whole row
-
-        switch (ctrl.build.outcome) {
-          default:
-            break;
-          case 'failed':
-            $element.addClass('table-danger');
-            break;
-        }
+        this.$onInit = function() {
+          switch (this.build.outcome) {
+            default:
+              break;
+            case 'failed':
+              $element.addClass('table-danger');
+              break;
+          }
+        };
 
         Object.defineProperties(this, {
           committerTitle: {

diff --git a/source/scripts/MainComponent.js b/source/scripts/MainComponent.js
@@ -19,11 +19,13 @@
         BuildService.stopPolling();
       };
 
-      if (this.apiToken) {
-        $log.info('apiToken found, start polling');
-        BuildService.apiToken = this.apiToken;
-        BuildService.startPolling(this.refreshInterval);
-      }
+      this.$onInit = function() {
+        if (this.apiToken) {
+          $log.info('apiToken found, start polling');
+          BuildService.apiToken = this.apiToken;
+          BuildService.startPolling(this.refreshInterval);
+        }
+      };
     }
   });
 })();
-Original file line number
+Diff line change
@@ Expand Up / @@ -9,7 +9,6 @@ @@
         },
         templateUrl: 'scripts/BuildList.html',
         controller: function() {
         }
       });
     })();