Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bootstrap lambkin-shepherd documentation #48

Merged
merged 2 commits into from
May 9, 2023
Merged

Bootstrap lambkin-shepherd documentation #48

merged 2 commits into from
May 9, 2023

Conversation

hidmic
Copy link
Collaborator

@hidmic hidmic commented May 8, 2023

Proposed changes

This patch sets up lambkin-shepherd documentation using sphinx. That's easier said than done, as RobotFramework tooling for documentation is... bad, let's stay with bad. This autorobot Sphinx extension is what I came up with to address that. I was planning to polish the package documentation before submitting this PR, but let's review this first.

Connected to #18 and #44.

Type of change

  • 🐛 Bugfix (change which fixes an issue)
  • 🚀 Feature (change which adds functionality)
  • 📚 Documentation (change which fixes or extends documentation)

Checklist

  • Lint and unit tests (if any) pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Additional comments

This patch is lacking linters for ReST documents. That will come later, with the rest of the documentation. Also, I did not add any tests for the autorobot extension. I don't think it's worth it.

@hidmic hidmic requested a review from nahueespinosa May 8, 2023 23:25
@hidmic
Copy link
Collaborator Author

hidmic commented May 8, 2023

Also, @francocipollone PTAL.

Copy link
Collaborator

@francocipollone francocipollone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Tried it locally and works as a charm.


```sh
cd docs
make html
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed to run this within the shell?

poetry run make html

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

poetry run is already used within the Makefile.

@@ -0,0 +1,413 @@
import contextlib
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing license?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Fixed in 2f8554c.

Signed-off-by: Michel Hidalgo <[email protected]>
@hidmic
Copy link
Collaborator Author

hidmic commented May 9, 2023

Moving forward.

@hidmic hidmic merged commit 1251ef6 into main May 9, 2023
@hidmic hidmic deleted the hidmic/docs branch May 9, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants