Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Travis CI with GitHub Actions #13

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Replace Travis CI with GitHub Actions #13

wants to merge 2 commits into from

Conversation

rht
Copy link
Contributor

@rht rht commented Jan 3, 2021

travis-ci.org was shut down in Dec 31 2020, which leaves travis-ci.com which has limited credit for FOSS projects. So let's migrate to elsewhere. Let me know if you prefer Circle CI instead.

@rht
Copy link
Contributor Author

rht commented Jan 3, 2021

@rht
Copy link
Contributor Author

rht commented Jan 3, 2021

The GitHub Action build for this repo will be enabled as soon as this PR is merged. Currently, it only runs on my fork.

@rht
Copy link
Contributor Author

rht commented Jan 3, 2021

@svdhoog

@rht
Copy link
Contributor Author

rht commented Jan 3, 2021

The tests actually failed, and I observed, have failed for most of the recent PRs. Maybe there needs to be set -e? Fixing the test is outside the scope of this PR though.

@svdhoog
Copy link
Contributor

svdhoog commented Jan 8, 2021

@rht For what purpose would you like to use CI for this repo?

Note that the unittests for this repo are not up-to-date, so this explains why they fail.

Maybe there needs to be set -e?

If I am not mistaken, this is at the beginning of the install_flame.sh script?

@svdhoog svdhoog requested review from svdhoog and dkohlweyer January 8, 2021 22:39
@svdhoog svdhoog added the enhancement New feature or request label Jan 8, 2021
@rht
Copy link
Contributor Author

rht commented Jan 9, 2021

@rht For what purpose would you like to use CI for this repo?

Just for assurance that there are no bugs creeping in through the changes.

Note that the unittests for this repo are not up-to-date, so this explains why they fail.

Oh I see. IIRC they used to work during the early days when this repo went public. So the mismatch is caused by the recent commits?

@rht
Copy link
Contributor Author

rht commented Jan 9, 2021

If I am not mistaken, this is at the beginning of the install_flame.sh script?

I saw that it is there in install_flame.sh, so the install can notify a failure, but it appears that set -e inside run_tests.sh is commented out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants