Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to src/ layout #102

Merged
merged 3 commits into from
Sep 13, 2021
Merged

Change to src/ layout #102

merged 3 commits into from
Sep 13, 2021

Conversation

nicoddemus
Copy link
Member

This is nowdays considered best practice, and in line with our other repos on GitHub.

This is nowdays considered best practice, and in line with our other repos on GitHub.
base_environment.yml Show resolved Hide resolved
@prusse-martin
Copy link
Member

You will probably also want to update https://github.com/ESSS/qmxgraph/blob/master/docs/conf.py#L23.
But since the documentation build is failing we can postpone this.

@prusse-martin
Copy link
Member

I did add 2 items to #37:

  • Fix documentation build;
  • Check and update examples;

So we can merge this and review the docs later;

@nicoddemus
Copy link
Member Author

nicoddemus commented Sep 13, 2021

You will probably also want to update https://github.com/ESSS/qmxgraph/blob/master/docs/conf.py#L23.
But since the documentation build is failing we can postpone this.

Good point, but went ahead and removed that line: readthedocs has the option to install the project into a virtualenv to build the docs, which removes the need for that workaround. But we still need to fix #37 to get the documentation up and running, as you mentioned.

This is not really needed when building on readthedocs, because
it has the option to install the project into a virtualenv before
building the documentation.
@nicoddemus nicoddemus merged commit fb7afee into fb-ASIM-4290-linting Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants