Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use SubElement where possible when creating dom trees #285

Conversation

deichmab-draeger
Copy link
Member

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have updated the changelog accordingly.
  • I have added tests to cover my changes.

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (334d9b6) 89.69% compared to head (20e17c3) 89.69%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #285   +/-   ##
=======================================
  Coverage   89.69%   89.69%           
=======================================
  Files         115      115           
  Lines       13195    13190    -5     
=======================================
- Hits        11835    11831    -4     
+ Misses       1360     1359    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/sdc11073/xml_types/xml_structure.py Show resolved Hide resolved
tests/test_mdib.py Outdated Show resolved Hide resolved
tests/test_mdib.py Show resolved Hide resolved
@deichmab-draeger deichmab-draeger added the v2 Version 2 is affected label Dec 4, 2023
a-kleinf
a-kleinf previously approved these changes Dec 5, 2023
@deichmab-draeger deichmab-draeger merged commit d687a55 into Draegerwerk:master Dec 5, 2023
@deichmab-draeger deichmab-draeger deleted the fix/qname_prefix_in_node_text branch December 5, 2023 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v2 Version 2 is affected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants