Added /series/:id/episodes endpoint #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The models aren't fleshed out, I will update #6 tomorrow and create a new issue to update the models. Regarding the PR, it looks great, I just wasn't sure if we may need the Episode in other controller functions, but I we can just work with objects. I will merge it and if we need it in the future it would be a pretty fast fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented for #25
I created episode as a schema but if an episode should not contain an id, it can be changed. Also, episode may contain more information than just name. I couldn't decide it exactly. Season number, episode number etc. can be included.