This repository has been archived by the owner on Jul 1, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 44
Put explanations next to suggestions #265
Draft
jablko
wants to merge
19
commits into
DefinitelyTyped:master
Choose a base branch
from
jablko:patch-35
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Took me a while to figure out that this is adding two commits to #235. I'll make it a draft so it won't be confusing... |
jablko
force-pushed
the
patch-35
branch
6 times, most recently
from
December 16, 2020 17:11
621997b
to
100ec13
Compare
jablko
force-pushed
the
patch-35
branch
2 times, most recently
from
December 22, 2020 14:54
a0612cc
to
890c778
Compare
jablko
force-pushed
the
patch-35
branch
4 times, most recently
from
January 20, 2021 22:59
cc2425d
to
ee1e6b7
Compare
Co-authored-by: Eli Barzilay <[email protected]>
elibarzilay
force-pushed
the
master
branch
3 times, most recently
from
July 7, 2021 15:39
1d39a68
to
9e931d1
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #235
editsConfig
files identically to theeditsInfra
files in the welcome comment