-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move simplecov patch to an overlay in our tree instead of using a forked simplecov repo #4263
Conversation
Thank you for updating Change log entry section 👏 Visited at: 2025-01-08 05:00:05 UTC |
Datadog ReportBranch report: ✅ 0 Failed, 22497 Passed, 1488 Skipped, 6m 1.72s Total Time New Flaky Tests (1)
|
904c45a
to
5e01e5b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4263 +/- ##
=======================================
Coverage 97.74% 97.75%
=======================================
Files 1353 1353
Lines 82392 82392
Branches 4224 4224
=======================================
+ Hits 80536 80540 +4
+ Misses 1856 1852 -4 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM. This workaround seems much nicer than needing to carry our own fork just for simplecov-ruby/simplecov#972 .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
* master: DEBUG-3210 DI: change logging to be appropriate for customer inspection (DataDog#4266) Report timing information if try_wait_until times out (DataDog#4265) Move simplecov patch to an overlay in our tree instead of using a forked simplecov repo (DataDog#4263) DEBUG-3251 dependency inject logger into DI component (DataDog#4262) DEBUG-3182 move Rails utils to core (DataDog#4261) add supported versions workflow (DataDog#4210) DEBUG-3305 remove dependency on benchmark (DataDog#4259) Fix case & grammar in issue template (DataDog#4244) [🤖] Update Latest Dependency: https://github.com/DataDog/dd-trace-rb/actions/runs/12614773826
What does this PR do?
Moves the patch for simplecov not being able to combine jruby and MRI coverage reports to our repo.
Motivation:
bundler is constantly asking to reinstall simplecov from the fork
Change log entry
None
Additional Notes:
How to test the change?