Skip to content

Commit

Permalink
Work around missing logger dependency in Rails 6.1 and 7.0 (#4298)
Browse files Browse the repository at this point in the history
Co-authored-by: Oleg Pudeyev <[email protected]>
  • Loading branch information
p-datadog and p authored Jan 16, 2025
1 parent 4bdcc0f commit b5cf594
Show file tree
Hide file tree
Showing 2 changed files with 21 additions and 0 deletions.
11 changes: 11 additions & 0 deletions integration/apps/rails-seven/Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -49,3 +49,14 @@ end
# Gems no longer included in Ruby 3.4
gem 'bigdecimal'
gem 'mutex_m'

# concurrent-ruby 1.3.5 removed dependency on logger, see:
# https://github.com/ruby-concurrency/concurrent-ruby/commit/d7ce956dacd0b772273d39b8ed31a30cff7ecf38
# Unfortunately this broke Rails because ActiveSupport used Logger
# before requiring logger.
# Since the failure happens rather early in rails bootstrapping,
# patching it is difficult, thus downgrade concurrent-ruby.
# The issue is fixed in 7-0-stable and should be shipped in the release
# after 7.0.8.7, at which point the pin of concurrent-ruby should be removed.
# See https://github.com/rails/rails/issues/54263
gem 'concurrent-ruby', '1.3.4'
10 changes: 10 additions & 0 deletions integration/apps/rails-six/Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -105,3 +105,13 @@ end

# Gem no longer included in Ruby 3.4
gem 'mutex_m'

# concurrent-ruby 1.3.5 removed dependency on logger, see:
# https://github.com/ruby-concurrency/concurrent-ruby/commit/d7ce956dacd0b772273d39b8ed31a30cff7ecf38
# Unfortunately this broke Rails because ActiveSupport used Logger
# before requiring logger.
# Since the failure happens rather early in rails bootstrapping,
# patching it is difficult, thus downgrade concurrent-ruby.
# The issue affects Rails 6.1 where apparently it will be never fixed
# (unlike Rails 7.0 which is fixed in https://github.com/rails/rails/issues/54263).
gem 'concurrent-ruby', '1.3.4'

0 comments on commit b5cf594

Please sign in to comment.