Skip to content

Commit

Permalink
apply fix to all rails versions
Browse files Browse the repository at this point in the history
  • Loading branch information
p committed Jan 16, 2025
1 parent a5636a9 commit 6f9a8ef
Show file tree
Hide file tree
Showing 3 changed files with 25 additions and 4 deletions.
10 changes: 10 additions & 0 deletions integration/apps/rails-five/Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -89,3 +89,13 @@ group :test, :development do

gem 'listen'
end

# concurrent-ruby 1.3.5 removed dependency on logger, see:
# https://github.com/ruby-concurrency/concurrent-ruby/commit/d7ce956dacd0b772273d39b8ed31a30cff7ecf38
# Unfortunately this broke Rails because ActiveSupport used Logger
# before requiring logger.
# Since the failure happens rather early in rails bootstrapping,
# patching it is difficult, thus downgrade concurrent-ruby.
# The issue appears to affect all existing Rails versions:
# https://github.com/rails/rails/blob/main/activesupport/lib/active_support/logger.rb#L4-L5
gem 'concurrent-ruby', '1.3.4'
10 changes: 10 additions & 0 deletions integration/apps/rails-seven/Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -49,3 +49,13 @@ end
# Gems no longer included in Ruby 3.4
gem 'bigdecimal'
gem 'mutex_m'

# concurrent-ruby 1.3.5 removed dependency on logger, see:
# https://github.com/ruby-concurrency/concurrent-ruby/commit/d7ce956dacd0b772273d39b8ed31a30cff7ecf38
# Unfortunately this broke Rails because ActiveSupport used Logger
# before requiring logger.
# Since the failure happens rather early in rails bootstrapping,
# patching it is difficult, thus downgrade concurrent-ruby.
# The issue appears to affect all existing Rails versions:
# https://github.com/rails/rails/blob/main/activesupport/lib/active_support/logger.rb#L4-L5
gem 'concurrent-ruby', '1.3.4'
9 changes: 5 additions & 4 deletions integration/apps/rails-six/Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -108,9 +108,10 @@ gem 'mutex_m'

# concurrent-ruby 1.3.5 removed dependency on logger, see:
# https://github.com/ruby-concurrency/concurrent-ruby/commit/d7ce956dacd0b772273d39b8ed31a30cff7ecf38
# Unfortunately this broke rails because ActiveSupport used Logger
# but didn't require logger.
# Unfortunately this broke Rails because ActiveSupport used Logger
# before requiring logger.
# Since the failure happens rather early in rails bootstrapping,
# patching it is difficult, thus downgrade concurrent-ruby for Rails 6.
# The issue does not occur in Rails 7.
# patching it is difficult, thus downgrade concurrent-ruby.
# The issue appears to affect all existing Rails versions:
# https://github.com/rails/rails/blob/main/activesupport/lib/active_support/logger.rb#L4-L5
gem 'concurrent-ruby', '1.3.4'

0 comments on commit 6f9a8ef

Please sign in to comment.